-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct FIL export format for sklearn/cuml to treelite checkpoint #124
Correct FIL export format for sklearn/cuml to treelite checkpoint #124
Conversation
Click to view CI ResultsGitHub pull request #124 of commit eaeb8f4a5b0833021e0f4bd23f3cd97e91f62494, no merge conflicts. Running as SYSTEM Setting status of eaeb8f4a5b0833021e0f4bd23f3cd97e91f62494 to PENDING with url https://10.20.13.93:8080/job/merlin_systems/96/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_systems using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/124/*:refs/remotes/origin/pr/124/* # timeout=10 > git rev-parse eaeb8f4a5b0833021e0f4bd23f3cd97e91f62494^{commit} # timeout=10 Checking out Revision eaeb8f4a5b0833021e0f4bd23f3cd97e91f62494 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f eaeb8f4a5b0833021e0f4bd23f3cd97e91f62494 # timeout=10 Commit message: "Add test for exported fil model filenames" > git rev-list --no-walk 644c74ae55dbd17cb11e55e44b438f8ab9bfc9b1 # timeout=10 [merlin_systems] $ /bin/bash /tmp/jenkins5571583820072609199.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 17 items / 2 skipped |
Documentation preview |
Click to view CI ResultsGitHub pull request #124 of commit 976729d00438fe722aea2ff985f998349e2b1a8a, no merge conflicts. Running as SYSTEM Setting status of 976729d00438fe722aea2ff985f998349e2b1a8a to PENDING with url https://10.20.13.93:8080/job/merlin_systems/97/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_systems using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/124/*:refs/remotes/origin/pr/124/* # timeout=10 > git rev-parse 976729d00438fe722aea2ff985f998349e2b1a8a^{commit} # timeout=10 Checking out Revision 976729d00438fe722aea2ff985f998349e2b1a8a (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 976729d00438fe722aea2ff985f998349e2b1a8a # timeout=10 Commit message: "Add treelite dependencies to fil workflow" > git rev-list --no-walk eaeb8f4a5b0833021e0f4bd23f3cd97e91f62494 # timeout=10 [merlin_systems] $ /bin/bash /tmp/jenkins2747109493792480676.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 17 items / 2 skipped |
|
||
def save(self, version_path): | ||
"""Save model to version_path.""" | ||
model_path = pathlib.Path(version_path) / self.model_filename | ||
with open(model_path, "wb") as model_file: | ||
pickle.dump(self.model, model_file) | ||
self.model.convert_to_treelite_model().to_treelite_checkpoint(str(model_path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we haven't currently got cuml
installed in the test env, so this is untested in CI currently
Click to view CI ResultsGitHub pull request #124 of commit fc4e464729df3bd367bb990310b5f2119af35a46, no merge conflicts. Running as SYSTEM Setting status of fc4e464729df3bd367bb990310b5f2119af35a46 to PENDING with url https://10.20.13.93:8080/job/merlin_systems/99/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_systems using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/124/*:refs/remotes/origin/pr/124/* # timeout=10 > git rev-parse fc4e464729df3bd367bb990310b5f2119af35a46^{commit} # timeout=10 Checking out Revision fc4e464729df3bd367bb990310b5f2119af35a46 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f fc4e464729df3bd367bb990310b5f2119af35a46 # timeout=10 Commit message: "Merge branch 'main' into fil-treelite-checkpoint" > git rev-list --no-walk 0d4edc87c4b65e32cacf09ff459314a943375fb0 # timeout=10 [merlin_systems] $ /bin/bash /tmp/jenkins14804937426934297153.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 17 items / 2 skipped |
@jperez999 There might be some additional dependencies to add to the CI environments from this PR too |
Click to view CI ResultsGitHub pull request #124 of commit d1785a8a3f0e2eb07eaf2d21ed52e287a12f76ef, no merge conflicts. Running as SYSTEM Setting status of d1785a8a3f0e2eb07eaf2d21ed52e287a12f76ef to PENDING with url https://10.20.13.93:8080/job/merlin_systems/101/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_systems using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/124/*:refs/remotes/origin/pr/124/* # timeout=10 > git rev-parse d1785a8a3f0e2eb07eaf2d21ed52e287a12f76ef^{commit} # timeout=10 Checking out Revision d1785a8a3f0e2eb07eaf2d21ed52e287a12f76ef (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f d1785a8a3f0e2eb07eaf2d21ed52e287a12f76ef # timeout=10 Commit message: "Add test for FIL ensemble with sklearn treelite checkpoint" > git rev-list --no-walk 8986c8a491173b051732e8d54adbbcd04cca1454 # timeout=10 [merlin_systems] $ /bin/bash /tmp/jenkins8448001381901058517.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 18 items / 2 skipped |
Click to view CI ResultsGitHub pull request #124 of commit 078e196a5d84e2e5e41d9cfd50c26fb783162109, no merge conflicts. Running as SYSTEM Setting status of 078e196a5d84e2e5e41d9cfd50c26fb783162109 to PENDING with url https://10.20.13.93:8080/job/merlin_systems/102/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_systems using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/124/*:refs/remotes/origin/pr/124/* # timeout=10 > git rev-parse 078e196a5d84e2e5e41d9cfd50c26fb783162109^{commit} # timeout=10 Checking out Revision 078e196a5d84e2e5e41d9cfd50c26fb783162109 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 078e196a5d84e2e5e41d9cfd50c26fb783162109 # timeout=10 Commit message: "Move ensemble treelite test from test_ensemble to test_forest" > git rev-list --no-walk d1785a8a3f0e2eb07eaf2d21ed52e287a12f76ef # timeout=10 [merlin_systems] $ /bin/bash /tmp/jenkins18228505484791559165.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 17 items / 2 skipped |
078e196
to
fc4e464
Compare
Click to view CI ResultsGitHub pull request #124 of commit fc4e464729df3bd367bb990310b5f2119af35a46, no merge conflicts. Running as SYSTEM Setting status of fc4e464729df3bd367bb990310b5f2119af35a46 to PENDING with url https://10.20.13.93:8080/job/merlin_systems/104/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_systems using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/124/*:refs/remotes/origin/pr/124/* # timeout=10 > git rev-parse fc4e464729df3bd367bb990310b5f2119af35a46^{commit} # timeout=10 Checking out Revision fc4e464729df3bd367bb990310b5f2119af35a46 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f fc4e464729df3bd367bb990310b5f2119af35a46 # timeout=10 Commit message: "Merge branch 'main' into fil-treelite-checkpoint" > git rev-list --no-walk 0d4edc87c4b65e32cacf09ff459314a943375fb0 # timeout=10 [merlin_systems] $ /bin/bash /tmp/jenkins11772426066268581552.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 17 items / 2 skipped |
Correct FIL export format for sklearn/cuml to treelite checkpoint.
This requires
treelite
andtreelite_runtime
packages and the version must match the triton version to work correctly.