Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Formatter (Prettier) for YAML and Markdown files #1733

Merged
merged 6 commits into from
Jan 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: Bug report
about: Create a bug report to help us improve NVTabular
title: "[BUG]"
labels: "? - Needs Triage, bug"
assignees: ''

assignees: ""
---

**Describe the bug**
Expand All @@ -17,10 +16,10 @@ Follow this guide http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-rep
A clear and concise description of what you expected to happen.

**Environment details (please complete the following information):**
- Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)]
- Method of NVTabular install: [conda, Docker, or from source]
- If method of install is [Docker], provide `docker pull` & `docker run` commands used


- Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)]
- Method of NVTabular install: [conda, Docker, or from source]
- If method of install is [Docker], provide `docker pull` & `docker run` commands used

**Additional context**
Add any other context about the problem here.
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/documentation-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: Documentation request
about: Report incorrect or needed documentation
title: "[DOC]"
labels: "? - Needs Triage, doc"
assignees: ''

assignees: ""
---

## Report incorrect documentation
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: Feature request
about: Suggest an idea for NVTabular
title: "[FEA]"
labels: "? - Needs Triage, feature request"
assignees: ''

assignees: ""
---

**Is your feature request related to a problem? Please describe.**
Expand Down
14 changes: 8 additions & 6 deletions .github/ISSUE_TEMPLATE/operator_request.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
---

name: Operator request
about: Suggest an operator for NVTabular to do [...]

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Describe the solution you'd like**
A clear and concise description of the operation you'd like to perform on the column. Please include:
- Type (Feature Engineering or Preprocessing)
- input column type(s)
- output column type(s)
- Expected transformation of the data after application
A clear and concise description of the operation you'd like to perform on the column. Please include:

- Type (Feature Engineering or Preprocessing)
- input column type(s)
- output column type(s)
- Expected transformation of the data after application

**Optional: Describe operation stages in detail***
**Optional: Describe operation stages in detail\***
Statistics per chunk: Ex. compute the mean, stdev and count of the column
Statistics combine: Ex. combine means & stdevs after normalizing by total count
Apply: (value-mean)/stdev
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/research_question.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: Research Question
about: Longer term research related to NVTabular
title: "[REA]"
labels: "? - Proposed research topic"
assignees: ''

assignees: ""
---

**What questions are you trying to answer? Please describe.**
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/submit-question.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: Submit question
about: Ask a general question about NVTabular
title: "[QST]"
labels: "? - Needs Triage, question"
assignees: ''

assignees: ""
---

**What is your question?**
4 changes: 1 addition & 3 deletions .github/ISSUE_TEMPLATE/task.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@ name: Task
about: A general task that we're tracking in Github
title: "[Task]"
labels: ""
assignees: ''

assignees: ""
---

**What needs doing**


**Additional context**
Add any other context, code examples, or references to existing implementations about the task here.
44 changes: 22 additions & 22 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
categories:
- title: '⚠ Breaking Changes'
labels:
- 'breaking'
- title: '🐜 Bug Fixes'
labels:
- 'bug'
- title: '🚀 Features'
labels:
- 'feature'
- 'enhancement'
- title: '📄 Documentation'
labels:
- 'documentation'
- 'examples'
- title: '🔧 Maintenance'
labels:
- 'build'
- 'dependencies'
- 'chore'
- 'ci'
change-template: '- $TITLE @$AUTHOR (#$NUMBER)'
- title: "⚠ Breaking Changes"
labels:
- "breaking"
- title: "🐜 Bug Fixes"
labels:
- "bug"
- title: "🚀 Features"
labels:
- "feature"
- "enhancement"
- title: "📄 Documentation"
labels:
- "documentation"
- "examples"
- title: "🔧 Maintenance"
labels:
- "build"
- "dependencies"
- "chore"
- "ci"
change-template: "- $TITLE @$AUTHOR (#$NUMBER)"
exclude-labels:
- 'skip-changelog'
- "skip-changelog"
template: |
## What’s Changed

Expand Down
230 changes: 115 additions & 115 deletions .github/workflows/blossom-ci.yml
Original file line number Diff line number Diff line change
@@ -1,115 +1,115 @@
# Copyright (c) 2020-2021, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# A workflow to trigger ci on hybrid infra (github + self hosted runner)
name: Blossom-CI
on:
issue_comment:
types: [created]
workflow_dispatch:
inputs:
platform:
description: 'runs-on argument'
required: false
args:
description: 'argument'
required: false
jobs:
Authorization:
name: Authorization
runs-on: blossom
outputs:
args: ${{ env.args }}
# This job only runs for pull request comments
if: contains( '\
albert17,\
benfred,\
bschifferer,\
EvenOldridge,\
gabrielspmoreira,\
jperez999,\
karlhighley,\
marcromeyn,\
benfred,\
rjzamora,\
rnyak,\
sararb,\
', format('{0},', github.actor)) && github.event.comment.body == '/blossom-ci'
steps:
- name: Check if comment is issued by authorized person
run: blossom-ci
env:
OPERATION: 'AUTH'
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO_KEY_DATA: ${{ secrets.BLOSSOM_KEY }}
Vulnerability-scan:
name: Vulnerability scan
needs: [Authorization]
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
repository: ${{ fromJson(needs.Authorization.outputs.args).repo }}
ref: ${{ fromJson(needs.Authorization.outputs.args).ref }}
lfs: 'true'
# repo specific steps
#- name: Setup java
# uses: actions/setup-java@v1
# with:
# java-version: 1.8
# add blackduck properties https://synopsys.atlassian.net/wiki/spaces/INTDOCS/pages/631308372/Methods+for+Configuring+Analysis#Using-a-configuration-file
#- name: Setup blackduck properties
# run: |
# PROJECTS=$(mvn -am dependency:tree | grep maven-dependency-plugin | awk '{ out="com.nvidia:"$(NF-1);print out }' | grep rapids | xargs | sed -e 's/ /,/g')
# echo detect.maven.build.command="-pl=$PROJECTS -am" >> application.properties
# echo detect.maven.included.scopes=compile >> application.properties
- name: Run blossom action
uses: NVIDIA/blossom-action@main
env:
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO_KEY_DATA: ${{ secrets.BLOSSOM_KEY }}
with:
args1: ${{ fromJson(needs.Authorization.outputs.args).args1 }}
args2: ${{ fromJson(needs.Authorization.outputs.args).args2 }}
args3: ${{ fromJson(needs.Authorization.outputs.args).args3 }}
Job-trigger:
name: Start ci job
needs: [Vulnerability-scan]
runs-on: blossom
steps:
- name: Start ci job
run: blossom-ci
env:
OPERATION: 'START-CI-JOB'
CI_SERVER: ${{ secrets.CI_SERVER }}
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Post-processing:
name: Post processing
runs-on: blossom
if : github.event_name == 'workflow_dispatch'
steps:
- name: Start post processing
run: blossom-ci
env:
OPERATION: 'POST-PROCESSING'
CI_SERVER: ${{ secrets.CI_SERVER }}
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# Copyright (c) 2020-2021, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# A workflow to trigger ci on hybrid infra (github + self hosted runner)
name: Blossom-CI
on:
issue_comment:
types: [created]
workflow_dispatch:
inputs:
platform:
description: "runs-on argument"
required: false
args:
description: "argument"
required: false
jobs:
Authorization:
name: Authorization
runs-on: blossom
outputs:
args: ${{ env.args }}

# This job only runs for pull request comments
if: contains( '\
albert17,\
benfred,\
bschifferer,\
EvenOldridge,\
gabrielspmoreira,\
jperez999,\
karlhighley,\
marcromeyn,\
benfred,\
rjzamora,\
rnyak,\
sararb,\
', format('{0},', github.actor)) && github.event.comment.body == '/blossom-ci'
steps:
- name: Check if comment is issued by authorized person
run: blossom-ci
env:
OPERATION: "AUTH"
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO_KEY_DATA: ${{ secrets.BLOSSOM_KEY }}

Vulnerability-scan:
name: Vulnerability scan
needs: [Authorization]
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
repository: ${{ fromJson(needs.Authorization.outputs.args).repo }}
ref: ${{ fromJson(needs.Authorization.outputs.args).ref }}
lfs: "true"

# repo specific steps
#- name: Setup java
# uses: actions/setup-java@v1
# with:
# java-version: 1.8

# add blackduck properties https://synopsys.atlassian.net/wiki/spaces/INTDOCS/pages/631308372/Methods+for+Configuring+Analysis#Using-a-configuration-file
#- name: Setup blackduck properties
# run: |
# PROJECTS=$(mvn -am dependency:tree | grep maven-dependency-plugin | awk '{ out="com.nvidia:"$(NF-1);print out }' | grep rapids | xargs | sed -e 's/ /,/g')
# echo detect.maven.build.command="-pl=$PROJECTS -am" >> application.properties
# echo detect.maven.included.scopes=compile >> application.properties

- name: Run blossom action
uses: NVIDIA/blossom-action@main
env:
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO_KEY_DATA: ${{ secrets.BLOSSOM_KEY }}
with:
args1: ${{ fromJson(needs.Authorization.outputs.args).args1 }}
args2: ${{ fromJson(needs.Authorization.outputs.args).args2 }}
args3: ${{ fromJson(needs.Authorization.outputs.args).args3 }}

Job-trigger:
name: Start ci job
needs: [Vulnerability-scan]
runs-on: blossom
steps:
- name: Start ci job
run: blossom-ci
env:
OPERATION: "START-CI-JOB"
CI_SERVER: ${{ secrets.CI_SERVER }}
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Post-processing:
name: Post processing
runs-on: blossom
if: github.event_name == 'workflow_dispatch'
steps:
- name: Start post processing
run: blossom-ci
env:
OPERATION: "POST-PROCESSING"
CI_SERVER: ${{ secrets.CI_SERVER }}
REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading