-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up tox
environments for testing, linting, and building docs
#1667
Conversation
Click to view CI ResultsGitHub pull request #1667 of commit 7d3f2b0db28860de634504e79b1d47010f55b859, no merge conflicts. Running as SYSTEM Setting status of 7d3f2b0db28860de634504e79b1d47010f55b859 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4671/ and message: 'Build started for merge commit.' Using context: Jenkins Unit Test Run Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests using credential nvidia-merlin-bot Cloning the remote Git repository Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git > git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git > git --version # timeout=10 using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1667/*:refs/remotes/origin/pr/1667/* # timeout=10 > git rev-parse 7d3f2b0db28860de634504e79b1d47010f55b859^{commit} # timeout=10 Checking out Revision 7d3f2b0db28860de634504e79b1d47010f55b859 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 7d3f2b0db28860de634504e79b1d47010f55b859 # timeout=10 Commit message: "Set up `tox` environments for testing, linting, and building docs" > git rev-list --no-walk 15f45d17d73c173a168fe178b330d57ec5c446f4 # timeout=10 First time build. Skipping changelog. [nvtabular_tests] $ /bin/bash /tmp/jenkins16103278925441821250.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1430 items / 1 skipped |
Click to view CI ResultsGitHub pull request #1667 of commit 5d4f19c235fef28a30f76f86c48d3a6d19853bfa, no merge conflicts. Running as SYSTEM Setting status of 5d4f19c235fef28a30f76f86c48d3a6d19853bfa to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4672/ and message: 'Build started for merge commit.' Using context: Jenkins Unit Test Run Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests using credential nvidia-merlin-bot Cloning the remote Git repository Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git > git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git > git --version # timeout=10 using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1667/*:refs/remotes/origin/pr/1667/* # timeout=10 > git rev-parse 5d4f19c235fef28a30f76f86c48d3a6d19853bfa^{commit} # timeout=10 Checking out Revision 5d4f19c235fef28a30f76f86c48d3a6d19853bfa (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 5d4f19c235fef28a30f76f86c48d3a6d19853bfa # timeout=10 Commit message: "Move `pybind11` to the dev requirements for the `tox` linting env" > git rev-list --no-walk 7d3f2b0db28860de634504e79b1d47010f55b859 # timeout=10 [nvtabular_tests] $ /bin/bash /tmp/jenkins16816760219173586233.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1430 items / 1 skipped |
Click to view CI ResultsGitHub pull request #1667 of commit 2fcdf0bbd58525a22cfe4e2b9af82d534ea115a4, no merge conflicts. Running as SYSTEM Setting status of 2fcdf0bbd58525a22cfe4e2b9af82d534ea115a4 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4673/ and message: 'Build started for merge commit.' Using context: Jenkins Unit Test Run Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests using credential nvidia-merlin-bot Cloning the remote Git repository Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git > git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git > git --version # timeout=10 using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1667/*:refs/remotes/origin/pr/1667/* # timeout=10 > git rev-parse 2fcdf0bbd58525a22cfe4e2b9af82d534ea115a4^{commit} # timeout=10 Checking out Revision 2fcdf0bbd58525a22cfe4e2b9af82d534ea115a4 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 2fcdf0bbd58525a22cfe4e2b9af82d534ea115a4 # timeout=10 Commit message: "Move `pybind11` to the cpu-ci action" > git rev-list --no-walk 5d4f19c235fef28a30f76f86c48d3a6d19853bfa # timeout=10 [nvtabular_tests] $ /bin/bash /tmp/jenkins101391932436102689.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1430 items / 1 skipped |
Click to view CI ResultsGitHub pull request #1667 of commit aff0fd89e1256d9a607be298d52bf915e7b97458, no merge conflicts. Running as SYSTEM Setting status of aff0fd89e1256d9a607be298d52bf915e7b97458 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4674/ and message: 'Build started for merge commit.' Using context: Jenkins Unit Test Run Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests using credential nvidia-merlin-bot Cloning the remote Git repository Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git > git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git > git --version # timeout=10 using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1667/*:refs/remotes/origin/pr/1667/* # timeout=10 > git rev-parse aff0fd89e1256d9a607be298d52bf915e7b97458^{commit} # timeout=10 Checking out Revision aff0fd89e1256d9a607be298d52bf915e7b97458 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f aff0fd89e1256d9a607be298d52bf915e7b97458 # timeout=10 Commit message: "Add `sklearn` to test dependencies" > git rev-list --no-walk 2fcdf0bbd58525a22cfe4e2b9af82d534ea115a4 # timeout=10 [nvtabular_tests] $ /bin/bash /tmp/jenkins982198990215251447.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1430 items / 1 skipped |
Click to view CI ResultsGitHub pull request #1667 of commit 83528e4a63a3c10dfdb67a9cbbb9fc29346b28b7, no merge conflicts. Running as SYSTEM Setting status of 83528e4a63a3c10dfdb67a9cbbb9fc29346b28b7 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4679/ and message: 'Build started for merge commit.' Using context: Jenkins Unit Test Run Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests using credential nvidia-merlin-bot Cloning the remote Git repository Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git > git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git > git --version # timeout=10 using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1667/*:refs/remotes/origin/pr/1667/* # timeout=10 > git rev-parse 83528e4a63a3c10dfdb67a9cbbb9fc29346b28b7^{commit} # timeout=10 Checking out Revision 83528e4a63a3c10dfdb67a9cbbb9fc29346b28b7 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 83528e4a63a3c10dfdb67a9cbbb9fc29346b28b7 # timeout=10 Commit message: "Add `clean` to docs Makefile" > git rev-list --no-walk 9f1465c37eb4401beae561566dea38a0b2a90088 # timeout=10 [nvtabular_tests] $ /bin/bash /tmp/jenkins14518839472531964498.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1430 items / 1 skipped |
Documentation preview |
Click to view CI ResultsGitHub pull request #1667 of commit a68cc2533be6f91dd49be96bd29828f327634359, no merge conflicts. Running as SYSTEM Setting status of a68cc2533be6f91dd49be96bd29828f327634359 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4680/ and message: 'Build started for merge commit.' Using context: Jenkins Unit Test Run Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests using credential nvidia-merlin-bot Cloning the remote Git repository Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git > git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git > git --version # timeout=10 using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1667/*:refs/remotes/origin/pr/1667/* # timeout=10 > git rev-parse a68cc2533be6f91dd49be96bd29828f327634359^{commit} # timeout=10 Checking out Revision a68cc2533be6f91dd49be96bd29828f327634359 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a68cc2533be6f91dd49be96bd29828f327634359 # timeout=10 Commit message: "Merge branch 'main' into refactor/tox-envs" > git rev-list --no-walk 83528e4a63a3c10dfdb67a9cbbb9fc29346b28b7 # timeout=10 [nvtabular_tests] $ /bin/bash /tmp/jenkins1262510767063583027.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 1429 items / 1 skipped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm Thank you.
) * Set up `tox` environments for testing, linting, and building docs * Move `pybind11` to the dev requirements for the `tox` linting env * Move `pybind11` to the cpu-ci action * Add `sklearn` to test dependencies * Update the CPU CI action to use `tox` to build docs * Update docs scheduled rebuild CI action to build with `tox` * Add `clean` to docs Makefile
This follows in the footsteps of the Systems and Core migrations to
tox
, which provides a degree of isolation for dependencies installed in the tests and allows us to run tests for downstream repos as part of our CI process.