Add scipy as a dependency
#1663
Conversation
NVTabular's dataset utils and `ColumnSimilarity` operator use `scipy` as a non-optional dependency, so it should be listed as a dependency here. Merlin Models relies on some of the functionality that uses `scipy`, which causes test errors in some environments.
karlhigley
added
dependencies
Click to view CI ResultsGitHub pull request #1663 of commit f356208333d74e8d54befa14a8c51ebcc7c7d940, no merge conflicts.
Running as SYSTEM
Setting status of f356208333d74e8d54befa14a8c51ebcc7c7d940 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4658/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests
using credential nvidia-merlin-bot
Cloning the remote Git repository
Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git
> git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
> git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1663/*:refs/remotes/origin/pr/1663/* # timeout=10
> git rev-parse f356208333d74e8d54befa14a8c51ebcc7c7d940^{commit} # timeout=10
Checking out Revision f356208333d74e8d54befa14a8c51ebcc7c7d940 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f f356208333d74e8d54befa14a8c51ebcc7c7d940 # timeout=10
Commit message: "Add `scipy` as a dependency"
> git rev-list --no-walk 64a0a71af9e99e6bfd3f698780ed360ee1ee2dc1 # timeout=10
First time build. Skipping changelog.
[nvtabular_tests] $ /bin/bash /tmp/jenkins12782292797340175355.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1430 items / 1 skipped
|
Documentation preview |
Click to view CI ResultsGitHub pull request #1663 of commit 607ec8aa8cffb0b3ae83bfa3852a248b9918a031, no merge conflicts.
Running as SYSTEM
Setting status of 607ec8aa8cffb0b3ae83bfa3852a248b9918a031 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4659/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests
using credential nvidia-merlin-bot
Cloning the remote Git repository
Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git
> git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
> git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1663/*:refs/remotes/origin/pr/1663/* # timeout=10
> git rev-parse 607ec8aa8cffb0b3ae83bfa3852a248b9918a031^{commit} # timeout=10
Checking out Revision 607ec8aa8cffb0b3ae83bfa3852a248b9918a031 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 607ec8aa8cffb0b3ae83bfa3852a248b9918a031 # timeout=10
Commit message: "Merge branch 'main' into deps/scipy"
> git rev-list --no-walk f356208333d74e8d54befa14a8c51ebcc7c7d940 # timeout=10
[nvtabular_tests] $ /bin/bash /tmp/jenkins9988584236700686194.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1430 items / 1 skipped
|
NVTabular's dataset utils and
ColumnSimilarityoperator usescipyas a non-optional dependency, so it should be listed as a dependency here. Merlin Models relies on some of the functionality that usesscipy, which causes test errors in some environments.