Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dl #1661

Merged
merged 7 commits into from
Aug 29, 2022
Merged

Fix dl #1661

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f7b8f2c
skip download step, that is not allowed in CI
jperez999 Jul 18, 2022
d1dcb82
Merge branch 'main' of https://github.com/NVIDIA-MERLIN/nvtabular
jperez999 Jul 18, 2022
57afb0f
Merge branch 'main' of https://github.com/NVIDIA-MERLIN/nvtabular
jperez999 Jul 19, 2022
c600258
Merge branch 'main' of https://github.com/NVIDIA-MERLIN/nvtabular
jperez999 Jul 20, 2022
463111e
Merge branch 'main' of https://github.com/NVIDIA-MERLIN/nvtabular int…
jperez999 Aug 23, 2022
3a06195
Merge branch 'main' of https://github.com/NVIDIA-MERLIN/nvtabular
jperez999 Aug 26, 2022
64a0a71
actual code added to DL
jperez999 Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions nvtabular/loader/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,12 +618,13 @@ def _handle_tensors(self, cats, conts, labels):
lists[names[0]] = tensor
X.update(lists)

for column_name in self.sparse_names:
if column_name not in self.sparse_max:
raise ValueError(
f"Did not convert {column_name} to sparse due to missing sparse_max entry"
)
X[column_name] = self._to_sparse_tensor(X[column_name], column_name)
for column_name in X:
if column_name in self.sparse_names:
if column_name not in self.sparse_max:
raise ValueError(
f"Did not convert {column_name} to sparse due to missing sparse_max entry"
)
X[column_name] = self._to_sparse_tensor(X[column_name], column_name)

# TODO: use dict for labels as well?
# would require output layers to match naming
Expand Down