Replace cudf series ceil() with numpy ceil() #1656
Conversation
Click to view CI ResultsGitHub pull request #1656 of commit b3dbcd871fca1f73aebd8fcd14d0e7f50c910f31, no merge conflicts.
Running as SYSTEM
Setting status of b3dbcd871fca1f73aebd8fcd14d0e7f50c910f31 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4645/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests
using credential nvidia-merlin-bot
Cloning the remote Git repository
Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git
> git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
> git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1656/*:refs/remotes/origin/pr/1656/* # timeout=10
> git rev-parse b3dbcd871fca1f73aebd8fcd14d0e7f50c910f31^{commit} # timeout=10
Checking out Revision b3dbcd871fca1f73aebd8fcd14d0e7f50c910f31 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f b3dbcd871fca1f73aebd8fcd14d0e7f50c910f31 # timeout=10
Commit message: "replace series ceil with np ceil because no longer available on series from cudf"
> git rev-list --no-walk 7ff98a4f2b978dcc5c1c3dcad001122eea28e52d # timeout=10
[nvtabular_tests] $ /bin/bash /tmp/jenkins2623636593658082086.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1430 items / 1 skipped
|
Documentation preview |
Click to view CI ResultsGitHub pull request #1656 of commit 2e673e0e23da9041f00c60dfbff482d563278a45, no merge conflicts.
Running as SYSTEM
Setting status of 2e673e0e23da9041f00c60dfbff482d563278a45 to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4646/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests
using credential nvidia-merlin-bot
Cloning the remote Git repository
Cloning repository https://github.com/NVIDIA-Merlin/NVTabular.git
> git init /var/jenkins_home/workspace/nvtabular_tests/nvtabular # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
> git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1656/*:refs/remotes/origin/pr/1656/* # timeout=10
> git rev-parse 2e673e0e23da9041f00c60dfbff482d563278a45^{commit} # timeout=10
Checking out Revision 2e673e0e23da9041f00c60dfbff482d563278a45 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 2e673e0e23da9041f00c60dfbff482d563278a45 # timeout=10
Commit message: "Merge branch 'main' into datagen_ceil"
> git rev-list --no-walk b3dbcd871fca1f73aebd8fcd14d0e7f50c910f31 # timeout=10
[nvtabular_tests] $ /bin/bash /tmp/jenkins13833051886711506506.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1430 items / 1 skipped
|
After 22.04, cudf series no longer supports the ceil() callable. Therefore, it has been replaced with numpy ceil to ensure longevity of support for dataset generator.