Update versioneer from 0.19 to 0.23
#1651
Conversation
|
I didn't intend to remove the
|
Click to view CI ResultsGitHub pull request #1651 of commit 8bd1260ba233898308f1416f79cefbd75013f4ff, no merge conflicts.
Running as SYSTEM
Setting status of 8bd1260ba233898308f1416f79cefbd75013f4ff to PENDING with url http://10.20.17.181:8080/job/nvtabular_tests/4625/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/nvtabular_tests
using credential nvidia-merlin-bot
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/NVTabular.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/NVTabular.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/NVTabular.git +refs/pull/1651/*:refs/remotes/origin/pr/1651/* # timeout=10
> git rev-parse 8bd1260ba233898308f1416f79cefbd75013f4ff^{commit} # timeout=10
Checking out Revision 8bd1260ba233898308f1416f79cefbd75013f4ff (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 8bd1260ba233898308f1416f79cefbd75013f4ff # timeout=10
Commit message: "Update `versioneer` from 0.19 to 0.23"
> git rev-list --no-walk 729eb88f3ebd2064c0eea2acb040ed23aa0e5191 # timeout=10
[nvtabular_tests] $ /bin/bash /tmp/jenkins3799432932522054226.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/nvtabular_tests/nvtabular, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1430 items / 1 skipped
|
|
Eh, it was debatable label anyway 🤷🏻 |
Documentation preview |
Goals ⚽
Restore editable install support with latest version of
setuptools(without requiring setting any environment variables to activate legacy support).Implementation Details 🚧
Ran the following
There are a few changes since we last configured versioneer (0.19).
The relevant change we're after to fix the editable install is in release 0.23 which added a patch for compatibility with the new
setuptoolsrelease.Testing Details 🔍
Checked that the following works locally:
pip install -e .