Skip to content

Commit

Permalink
Fix movielens notebook data path (#1622)
Browse files Browse the repository at this point in the history
* skip download step, that is not allowed in CI

* fix nb path to data

* fix inference call to incorrect path
  • Loading branch information
jperez999 authored Jul 18, 2022
1 parent 844ed61 commit 298aec8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@
}
],
"source": [
"ratings = df_lib.read_csv(os.path.join(INPUT_DATA_DIR, \"ml-25m\", \"ratings.csv\"))\n",
"ratings = df_lib.read_csv(os.path.join(INPUT_DATA_DIR, \"ratings.csv\"))\n",
"ratings.head()"
]
},
Expand Down
6 changes: 3 additions & 3 deletions tests/integration/test_rossman.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def test_rossman_tf(asv_db, bench_info, tmpdir, devices, report):
"""
)
tb_training.execute_cell(list(range(0, len(tb_training.cells))))
create_rossman_inference_data(INFERENCE_MULTI_HOT, DATA_DIR, output_path, 100)
create_rossman_inference_data(INFERENCE_MULTI_HOT, DATA_DIR, input_path, output_path, 100)
with test_utils.run_triton_server(
INFERENCE_MULTI_HOT,
"rossmann",
Expand Down Expand Up @@ -191,15 +191,15 @@ def test_rossman_fastai(asv_db, bench_info, tmpdir, devices, report):
tb_training.execute_cell(list(range(0, len(tb_training.cells))))


def create_rossman_inference_data(model_dir, data_dir, output_dir, nrows):
def create_rossman_inference_data(model_dir, data_dir, input_dir, output_dir, nrows):
import tensorflow as tf
from tensorflow import keras

from nvtabular.loader.tensorflow import KerasSequenceLoader

workflow_path = os.path.join(os.path.expanduser(model_dir), "rossmann_nvt/1/workflow")
model_path = os.path.join(os.path.expanduser(model_dir), "rossmann_tf/1/model.savedmodel")
data_path = os.path.join(os.path.expanduser(data_dir), "rossman/input/valid.csv")
data_path = os.path.join(os.path.expanduser(input_dir), "valid.csv")
output_dir = os.path.join(os.path.expanduser(output_dir), "rossman/")
os.makedirs(output_dir)
workflow_output_test_file_name = "test_inference_rossmann_data.csv"
Expand Down

0 comments on commit 298aec8

Please sign in to comment.