Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a maintenance guide page with information on maintaining vision #73

Merged
merged 48 commits into from
Aug 6, 2021

Conversation

ysims
Copy link
Member

@ysims ysims commented Oct 8, 2020

Maintenance for vision includes

  • Dataset generation
  • Training and testing the Visual Mesh (off-robot) and putting it into the NUbots main codebase
  • Camera calibration (more just linking to the page, but still waiting for that to go into master)
  • Testing the output of vision on the robot
  • Tuning detectors

Preview.

@ysims
Copy link
Member Author

ysims commented Jul 10, 2021

@KipHamiltons thanks for the good review, brought up some interesting considerations. Let me know what you think of my solutions, particularly on explaining commands every time or first time or make people go and search for things.

Copy link
Contributor

@BryceTuppurainen BryceTuppurainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run through this tutorial (excluding connecting to a bot by SSH) and it all seems clear and correct. The only point which was noted by Kip was that there should be a link to learn how to connect to the robot and use nano for file editing.

Although, this information can be found else-where on NUbook quite easily such as the getting started guide which has been linked on this page. This PR LGTM

Copy link
Member

@KipHamiltons KipHamiltons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!


## Vision

Before vision can work on the robot, odometry and kinematics must work on the robot. If these are inaccurate, then the green horizon is inaccurate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If odometry is bad the visual can also fail to detect anything (the mesh is either entirely offscreen or entirely/mostly off the field)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this part.

Copy link
Collaborator

@Bidski Bidski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@ysims ysims merged commit 969a813 into master Aug 6, 2021
@ysims ysims deleted the sims/guide-vision branch August 6, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants