-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a maintenance guide page with information on maintaining vision #73
Conversation
acquiring a dataset, training and testing the visual mesh, testing vision system on robot, and other considerations such as odometry and camera calibration.
and fixes links
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Joel Wong <[email protected]>
Co-authored-by: Kip Hamiltons <[email protected]>
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Josephus Paye II <[email protected]> Co-authored-by: Kip Hamiltons <[email protected]> Co-authored-by: Alex Biddulph <[email protected]>
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kip Hamiltons <[email protected]>
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
@KipHamiltons thanks for the good review, brought up some interesting considerations. Let me know what you think of my solutions, particularly on explaining commands every time or first time or make people go and search for things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run through this tutorial (excluding connecting to a bot by SSH) and it all seems clear and correct. The only point which was noted by Kip was that there should be a link to learn how to connect to the robot and use nano for file editing.
Although, this information can be found else-where on NUbook quite easily such as the getting started guide which has been linked on this page. This PR LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
src/book/03-guides/01-main-codebase/02-maintaining-subsystems.mdx
Outdated
Show resolved
Hide resolved
|
||
## Vision | ||
|
||
Before vision can work on the robot, odometry and kinematics must work on the robot. If these are inaccurate, then the green horizon is inaccurate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If odometry is bad the visual can also fail to detect anything (the mesh is either entirely offscreen or entirely/mostly off the field)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Maintenance for vision includes
Preview.