-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
コンポーネント整理 #318
base: develop
Are you sure you want to change the base?
コンポーネント整理 #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良いと思います。
よく考えたらiconFrameWorkからiconを作成しているのでiconsにまとめてもよさそうです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Components | |
export { default as Header } from "./Header"; | |
export { default as Modal } from "./Modal"; | |
export { default as Loading } from "./Loading"; | |
export { default as NavigationBar } from "./NavigationBar"; | |
export { default as ReactionStampModal } from "./ReactionStampModal"; | |
export { default as HelpCarousel } from "./HelpCarousel"; | |
export { default as ReachCount } from "./ReachCount"; | |
// Buttons | |
export { default as Button } from "./buttons/Button"; | |
export { default as ToggleButton } from "./buttons/ToggleButton"; | |
export { default as DotButton } from "./buttons/DotButton"; | |
// Icons | |
export { default as BingoIcon } from "./icons/BingoIcon"; | |
export { default as PrizesIcon } from "./icons/PrizesIcon"; | |
export { default as ReactionsIcon } from "./icons/ReactionsIcon"; | |
export { default as SettingsIcon } from "./icons/SettingsIcon"; | |
export { default as BackIcon } from "./icons/BackIcon"; | |
export { default as ReachIcon } from "./icons/ReachIcon"; | |
export { default as IconFramework } from "./icons/IconFramework"; | |
// Cards | |
export { default as NumberCardSmall } from "./cards/NumberCardSmall"; | |
export { default as NumberCardLarge } from "./NumberCardLarge"; | |
export { default as PrizeCard } from "./cards/PrizeCard"; | |
export { default as PrizeCardList } from "./cards/PrizeCardList"; | |
export { default as NumberCardList } from "./cards/NumberCardList"; | |
import React from "react"; | ||
import NumberCardSmall from "../NumberCardSmall"; | ||
|
||
import type { SubscribeListNumbersSubscription } from "@/types/graphql"; | ||
import styles from "./NumberCardList.module.css"; | ||
import NumberCardSmall from "../NumberCardSmall"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
view-user/next.config.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
おそらく直しました。
原因としてwebpackでimagesを再定義したことでremotePatternsが消えてしまったこと、"/bingo/**"というように前にスラッシュを付ける必要がある、であると思います。
images: {
remotePatterns: [
{
protocol: "http",
hostname: "minio",
port: "9000",
pathname: "/bingo/**",
},
{
protocol: "https",
hostname: "storage.nutfes.net",
pathname: "/**",
},
],
disableStaticImages: true,
},
webpack: (config) => {
config.module.rules.push({
test: /\.svg$/,
use: [
{
loader: "@svgr/webpack",
options: {
svgo: false,
},
},
],
});
return config;
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました。 |
対応Issue
概要
コンポーネント整理
実装詳細
以下の構造になるように各コンポーネントを移動
Components
├── Layout
├── common
│ ├── icons
│ │ ├── BackIcon
│ │ ├── BingoIcon
│ │ ├── PrizesIcon
│ │ ├── ReachIcon
│ │ ├── ReactionsIcon
│ │ ├── SettingsIcon
│ ├── buttons
│ │ ├── Button
│ │ ├── DotButton
│ │ ├── ToggleButton
│ ├── cards
│ │ ├── NumberCardList
│ │ ├── NumberCardSmall
│ │ ├── PrizeCard
│ │ ├── PrizeCardList
│ ├── Header
│ ├── HelpCarousel
│ ├── IconFramework
│ ├── Loading
│ ├── Modal
│ ├── NavigationBar
│ ├── ReachCount
│ ├── ReactionStampModal
│ └── index.ts
└── index.ts
画面スクリーンショット等
テスト項目
備考