-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serialization of state #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would separate the (de)serialization action in Python from the state getter/setter.
Should we also raise an error if the is false and the FMU user tries to call those functions?
Side question: regarding the integration test, would it be easy to set a CI job testing the capabilities through FMI4J
as it covers area not available through pyfmi
?
It's possible, but keeping it up to date is not so straightforward... So I dunno. If we get FMPy up and running we could use that. |
# Conflicts: # pythonfmu/fmi2slave.py
Thanks for the feedback. From my trial on subinterpreter, using FMPy seems really tricky. It may have something to do with how to interact with c code. |
How about this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the modifications. This fits perfectly what I meant.
There are just two typing changes to revert. But otherwise this is good to go.
Co-Authored-By: Frédéric Collonval <[email protected]>
Co-Authored-By: Frédéric Collonval <[email protected]>
Not able to test this using PyFMI as it raises a NotImplementedError.
But works with FMI4j.
Closes #54