Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sea action health check #60

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Sea action health check #60

merged 6 commits into from
Jan 5, 2023

Conversation

jhazentia
Copy link
Member

@jhazentia jhazentia commented Jan 3, 2023

Created as draft until #58 merged

  • monitor_action_completed signal changed to trigger_api_restart
  • data product action will call health check and send trigger_api_restart signal if needed
  • When checking if rf_path action parameter is provided, will check if preselector has rf_paths in sensor definition instead of just checking for preselector
  • Will only add extra entries to sigmf capture if extra entries is not None/empty

@jhazentia jhazentia marked this pull request as ready for review January 4, 2023 22:44
Copy link
Member

@aromanielloNTIA aromanielloNTIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should open a PR for the scos-tekrsa health check branch. See comment for one change below. PR approved if you disagree, otherwise approved after the change.

scos_actions/actions/acquire_sea_data_product.py Outdated Show resolved Hide resolved
scos_actions/metadata/sigmf_builder.py Show resolved Hide resolved
Copy link
Member

@aromanielloNTIA aromanielloNTIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants