Require classification metadata in YAML configs #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #41 by requiring action configs to specify the classification status of the data the action will produce. This value will be written to the SigMF
ntia-core
Measurement Object in the metadata produced by the action.Existing action configs will need to be updated to avoid errors, since time domain IQ actions and the M4S FFT action now both require a value for
classification
in their configs. Y-Factor action configs do not require aclassification
value, since they do not save SigMF metadata.Previously, results from these actions had no
classification
recorded in their metadata results, despite this technically being a required key according to thentia-core
specification. Since #32,classification
has been hard-coded asUNCLASSIFIED
.