Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require classification metadata in YAML configs #43

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

aromanielloNTIA
Copy link
Member

@aromanielloNTIA aromanielloNTIA commented Sep 8, 2022

Addresses #41 by requiring action configs to specify the classification status of the data the action will produce. This value will be written to the SigMF ntia-core Measurement Object in the metadata produced by the action.

Existing action configs will need to be updated to avoid errors, since time domain IQ actions and the M4S FFT action now both require a value for classification in their configs. Y-Factor action configs do not require a classification value, since they do not save SigMF metadata.

Previously, results from these actions had no classification recorded in their metadata results, despite this technically being a required key according to the ntia-core specification. Since #32, classification has been hard-coded as UNCLASSIFIED.

@dboulware dboulware merged commit 1646b3a into master Sep 8, 2022
@aromanielloNTIA aromanielloNTIA deleted the yaml-classification branch September 8, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants