Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for multi-antennas #122

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Conversation

ToddSchumannNTIA
Copy link
Contributor

No actual code changes needed to implement multi-antenna paths for the differential calibration. Just added a pytest for the new format.

Testing with two actions with a dummy differential calibration file with 10dB difference between the two antenna paths:

scos-sensor-api-1  | [2024-07-17 15:54:39,193] [DEBUG] Using sensor gain: 8.75119720678694 dB
scos-sensor-api-1  | [2024-07-17 15:54:39,193] [DEBUG] Using differential loss: 10.318735684035396 dB
scos-sensor-api-1  | [2024-07-17 15:54:39,193] [DEBUG] Applying total gain of -1.5675384772484549
scos-sensor-api-1  | [2024-07-17 15:56:15,601] [DEBUG] Using sensor gain: 30.097933572513824 dB
scos-sensor-api-1  | [2024-07-17 15:56:15,601] [DEBUG] Using differential loss: 20.538227261071448 dB
scos-sensor-api-1  | [2024-07-17 15:56:15,601] [DEBUG] Applying total gain of 9.559706311442376

@aromanielloNTIA aromanielloNTIA marked this pull request as draft July 17, 2024 16:54
@aromanielloNTIA aromanielloNTIA marked this pull request as ready for review July 17, 2024 16:54
@aromanielloNTIA
Copy link
Member

I'm not sure why my last commit didn't trigger Tox running on this branch, but I manually ran it on that commit. Tests all passed. Results available here.

The issue was unrelated to the changes in this PR- some SciPy functions changed to support fewer positional arguments, favoring keyword arguments, in v1.12.0. This caused the Tox testing with newer Python versions to fail. I updated every SciPy function to use only keyword arguments since it seems they might make similar changes in the future (e.g. here and here). This should help future-proof us from having similar issues down the line.

I also updated pre-commit hooks to latest versions and ran on all files.

Copy link
Member

@aromanielloNTIA aromanielloNTIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- thanks for adding the test case for this feature which was already supported but not tested. Testing on sensor (seadog02) also verified the changes.

@aromanielloNTIA aromanielloNTIA merged commit 23761e7 into master Jul 17, 2024
4 checks passed
@aromanielloNTIA aromanielloNTIA deleted the multiple-antenna-inputs branch July 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants