Timestamp issue, cleanup, other small improvements #12
Conversation
…dling of KDTree neighbor list, updated conversion functions, and removed file-finding logic specific to CHX's current ophyd object.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,351 @@ | |||
| { | |||
There was a problem hiding this comment.
It's great to have a few examples like this, however committing output cells of a notebook to a git repo is generally considered bad practice. We already have a tool, nbstripout, for cleaning up the notebooks before committing them. It can be activated as a pre-commit hook. Before committing, simply run pre-commit run --all (or pick a specific file) -- it will do some formatting, linting, and make sure the the code conforms to the stylistic standards.
|
@JGoodrichBNL could you please make this PR into my working branch, |
|
Merged these changes into PR #10. This PR can be closed. |
A bunch of changes, including the timestamp fixes from @josephhanrahan and @genematx, small optimizations of the clustering/centroiding, removing Databroker/CHX ophyd object-specific code, and other various cleanups and improvements.
We will likely use this code in our upcoming experiments (Aug 1st - Aug 4th), regardless if the PR is accepted, unless a major issue is discovered.