Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better shared memory handling? #40

Closed
leofang opened this issue May 14, 2019 · 5 comments
Closed

better shared memory handling? #40

leofang opened this issue May 14, 2019 · 5 comments

Comments

@leofang
Copy link
Collaborator

leofang commented May 14, 2019

If the GUI crashes very violently, it may be possible that the shared memory is not cleaned up. Try do a search (based on ownership) and clean up at GUI start time?

Challenges:

  • this seems to work only for Linux (with /dev/shm)?
@leofang
Copy link
Collaborator Author

leofang commented May 15, 2019

If the GUI crashes very violently, it may be possible that the shared memory is not cleaned up. Try do a search (based on ownership) and clean up at GUI start time?

Challenges:

  • this seems to work only for Linux (with /dev/shm)?

feeea9c now does this. Question: Do we want to do an automatic cleanup at GUI start time, or let users do it at will to avoid potential interference with existing GUI processes? I incline the former, but wanna make sure this is safe.

@leofang
Copy link
Collaborator Author

leofang commented May 15, 2019

Related: #41

@leofang
Copy link
Collaborator Author

leofang commented May 15, 2019

potential interference with existing GUI processes

One such possibility is this: the user starts the GUI in a terminal and then runs a reconstruction, and in the meantime the user starts the GUI in another terminal. If we do the cleanup at start time, the shared memory of the first GUI will be wiped out by the second GUI. Got to think a clever way (without locking I hope)...

@leofang
Copy link
Collaborator Author

leofang commented Jun 6, 2019

Related: 1d873d4

@leofang
Copy link
Collaborator Author

leofang commented Jun 6, 2019

Related: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant