Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.14.1 geoips - VERSION RELEASE - CI sync #791

Merged
merged 23 commits into from
Oct 15, 2024
Merged

Conversation

mindyls
Copy link
Contributor

@mindyls mindyls commented Sep 30, 2024

Related Issues

required to close #740
required to close

Reviewer Instructions

  • Please confirm this PR is set up to merge from v1.14.1-release branch into main branch
  • Review "Files changed" tab
  • Confirm appropriate testing was completed for these updates (you may perform tests yourself, or review output included from another reviewer/assignee)

Summary

Changes for version 1.14.1, uploaded with
1.14.1 update on repo geoips.
See release note updates in 'Files changed' tab

See #740 for additional repositories included in this update.
See for dev updates included in this update.

Testing Instructions

See #740 for testing instructions.

Output

See #740 for test output.

Post Merge Steps

Once this PR has been merged, v1.14.1
will be tagged/released on the geoips main branch.

@mindyls mindyls added the Version Release Version Release Updates label Sep 30, 2024
@mindyls mindyls self-assigned this Sep 30, 2024
@mindyls mindyls changed the title V1.14.1 version release v1.14.1 geoips - VERSION RELEASE - CI sync Sep 30, 2024
@mindyls
Copy link
Contributor Author

mindyls commented Oct 3, 2024

Note RST release note failure is due to header updates to existing RST release notes. These updates will not happen again, and no new RST release notes will ever be checked in, so we should merge with that CI failing. No other actions failed.

image

@mindyls
Copy link
Contributor Author

mindyls commented Oct 3, 2024

Ready to merge once we have 2 approvals and all conversations are resolved.

The one failing action is release note check - these just have header updates, and we should never have modifications to RST release note files again since we now auto-generate RST release notes. We should merge with this one remaining failing check since these are expected changes to existing RST release notes.

Additionally, CI is now working on other repositories (geoips_clavrx, geoips_plugin_example, geoips_tropics, ryglickicane, etc), though still fails for the fortran-based repos (including recenter_tc since it requires akima).

When this is merged we'll have to update the ruleset to point to main for doc-test.yaml

image

image

jsolbrig
jsolbrig previously approved these changes Oct 3, 2024
pyproject.toml Outdated Show resolved Hide resolved
cpcamacho
cpcamacho previously approved these changes Oct 4, 2024
@evrose54
Copy link
Contributor

evrose54 commented Oct 7, 2024

ami.tc.WV.geotiff.sh is still failing for me but everything else seems to be working! LGTM.

evrose54
evrose54 previously approved these changes Oct 7, 2024
@jsolbrig jsolbrig dismissed stale reviews from evrose54, cpcamacho, christopher-selman, and themself via e7d25a9 October 15, 2024 18:50
Copy link
Contributor

@jsolbrig jsolbrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is passing for me with one exception.

ami.tc.WV.geotiff.sh is failing. I'm not sure if this is a difference between the data that NRL and CIRA are using or if it is something else. The data range from 0 to 255. There are three pixels that differ by -2, 5, and 1, respectively.

I do not think that this difference is enough to warrant delaying this release any longer.

@jsolbrig jsolbrig merged commit dca02db into main Oct 15, 2024
12 of 13 checks passed
@jsolbrig jsolbrig deleted the v1.14.1-version-release branch October 15, 2024 21:42
@biosafetylvl5 biosafetylvl5 restored the v1.14.1-version-release branch October 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version Release Version Release Updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.13.2 - v1.14.0 Open Source Release
5 participants