Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoips#17 .github - Update pull request template to remove manual linking #1

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

mindyls
Copy link
Contributor

@mindyls mindyls commented Aug 1, 2022

Related Issue

NRLMMD-GEOIPS/geoips#17

Reviewer Checklist

Ensure you are logged into GitHub

Confirm all requirements are met for pull request

  • Ensure appropriate / sufficient content
    • Title format: geoips#<issue_num> <modified_repo_name> - <Short description>
      • Example: geoips#8 geoips_template_plugin - Updating GEOIPS_REPO_URL to github
    • Included Issue: Link to related Issue included at the beginning of pull request
      • Example: GEOIPS/geoips#8
    • CHANGELOG updated: Functionality included in pull request is ALSO referenced in CHANGELOG.md
    • Demonstrated Testing: Proper testing / output was demonstrated for functionality updates
    • Included Outputs: Imagery is included in "Output" section for new or changed product outputs (for reports!)
  • Ensure all appropriate tags / attributes added along right-hand side of pull request
    • Projects: GeoIPS - All Repos and All Functionality
      • Other projects allowed as appropriate
  • Ensure Related Issue is finalized appropriately (follow link above)
    • Check Issue Label: Issue ID label added to Issue in bright green

Once all items in checklist have been confirmed:

  • Approve pull request
    • Click "Files changed" tab
    • Click green "Review changes" button
    • Select "Approve" option
    • Add message if desired
    • Click green "Submit review" button
    • Project status will automatically be updated in Project "GeoIPS - All Repos and All Functionality" when pull request is approved.

Testing Instructions

Next PR that is opened will use the new PR template.

Summary

NRLMMD-GEOIPS/geoips#17 - Update github workflow to remove manual linking

Documentation Updates

  • pull_request_template.md
    • Remove all "labeling" requirements on pull requests (rely on automatic linking when creating branches)
    • Update GEOIPS to NRLMMD-GEOIPS organization
    • Add test script / test output requirement to PR review approval

Output

See next PR.

Documentation Updates
* **pull_request_template.md**
    * Remove all "labeling" requirements on pull requests (rely on automatic linking when creating branches)
    * Update GEOIPS to NRLMMD-GEOIPS organization
    * Add test script / test output requirement to PR review approval

NRLMMD-GEOIPS/geoips#17
@mindyls mindyls self-assigned this Aug 1, 2022
@mindyls mindyls linked an issue Aug 1, 2022 that may be closed by this pull request
4 tasks
@mindyls mindyls merged commit 76f9a39 into main Aug 1, 2022
@mindyls mindyls deleted the 17-update-git-workflow-for-githubcom-functionality-1 branch August 1, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update Git Workflow for GitHub.com functionality
3 participants