Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rjf/248 improve ksp #249

Merged
merged 16 commits into from
Aug 22, 2024
Merged

Rjf/248 improve ksp #249

merged 16 commits into from
Aug 22, 2024

Conversation

robfitzgerald
Copy link
Collaborator

This PR adds some new features to search:

  • Yen's k-Shortest Paths implementation
  • ksp termination criteria to give finer grain control over how many iterations are run
  • revised route similarity function for clearer semantics + call site
  • all search algorithms can receive JSON parameters from the search query
    • k, or A Star weight_factor are the first implementations

submitting this draft for any early review but I still need to test it later this week.

@robfitzgerald robfitzgerald marked this pull request as ready for review August 22, 2024 19:57
@robfitzgerald
Copy link
Collaborator Author

robfitzgerald commented Aug 22, 2024

@nreinicke this is ready for review. after running, i was able to explore k=[10,20,30,40,50] and plot which set each result comes from here, colored by it's k value, for a given OD pair. here stars are the time-optimized ksp routes, triangles are the distance-optimized ksp routes, and the circles are the pareto front generated by Compass.

pareto-all-kcolor-trip=9541722-model=BEV

i don't have any other tests, so if you feel like this could use a test, let me know.

Copy link
Collaborator

@nreinicke nreinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, it's cool to see the k paths building out the "cloud" around the Pareto front.

@robfitzgerald robfitzgerald merged commit 0eae046 into main Aug 22, 2024
5 checks passed
@robfitzgerald robfitzgerald deleted the rjf/248-improve-ksp branch August 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants