Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up TODOs prior to v4 release #876

Merged
merged 4 commits into from
Apr 7, 2024

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Apr 7, 2024

This PR is in preparation for v4, and removes redundant comments "TODO" and "v3".

Most changes are self-explanatory. Many TODOs are left, where they are still relevant. Slightly larger changes are:

  • move rotor_velocity_air_density_correction from operation_model.py to rotor_velocity.py for more consistent grouping of similar functions.
  • make yaw and tilt rotor effective velocity corrections explicitly based on a cosine correction
  • only "incorrect" references to v3 remaining that I found are in the .github/ directory, which will be updated just prior to release.

@misi9170 misi9170 changed the title Cleaning up comments (TODO, mentions of v3) Clean up TODOs prior to v4 release Apr 7, 2024
@misi9170 misi9170 merged commit c0d457f into NREL:v4 Apr 7, 2024
8 checks passed
@misi9170 misi9170 deleted the v4-ms/clean-up-TODO-v3 branch April 7, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant