-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor examples #843
Refactor examples #843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't examples 002--004 here covered by the 002_visualizations.py example in the main examples/ directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, yes, there a little more blocked out, but it's true not strictly necessary, but maybe convenient to have such a single-purpose example? Also up for discussion...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @paulf81 , I have made a bunch of minor comments, but overall this looks good.
I think the changes outside of the examples (heterogeneous
, bugfixes to ParallelFlorisModel
, MixedOperationTurbine
bugfix).
On the @property
s available on FlorisModel
, do we need to check that these are matched on UncertainFlorisModel
(I see that you've already updated ParallelFlorisModel
)?
Refactor examples for v4
This pull request refactors the examples around the v4 structures and style and in general cleans up the examples folder, which had become a sort of unsorted list of examples. Specifically,
In addition to these changes, some supporting changes were made to the code
Finally, changes to CI include:
@misi9170 and @rafmudaf and @ejsimley I think this is now ready to review. We talked about automatically generating html versions of the examples and so far this is proving difficult, so maybe that could still be done, but as part of another pull request