-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reference turbine model data #767
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain/floris/turbine_library/nrel_5MW.yaml with extension for before cut in and after cut out. Rename thrust field.
…hrust_coefficient key name.
… (tests need updating yet).
…MW turbine only, will remove prior to merge into v4 branch.
…mining baseline_ai.
Closing as superseded by #771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In converting from Cp to power curves as the standard for v4, we also noted that the data for some of the models in turbine library (most notably, the NREL 5MW) are out of date.
This pull request would update that data.
Impacted areas of the software
For discussion
A couple of important issues arise in this pull request, which may mean that we do not want to merge this as is. I will mark them complete once if/when we resolve these issues.