Resolution for the Internal ID bug #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than concatinate (str)
|
This looks great, thanks @Mkellyeng ! Don't mind the failed build, it looks like our CI setup needs some attention. |
This was referenced Mar 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make "largestID" sum with "v" (int) rather than concatenate (str)
Tested by creating a simple geometry with one space, saving, then adding a second space and saving again. Opening the first file and re-adding the second space, and saving for a third time. Before the change, this process produced different internal IDs in the second and third save files. After this change the IDs were identical, as intended