Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix pypi action to not use setup.py #229

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Oct 28, 2024

Fix the pypthon-publish action to work with pyproject.toml

@paulf81 paulf81 requested a review from misi9170 October 28, 2024 14:59
@paulf81 paulf81 self-assigned this Oct 28, 2024
@misi9170 misi9170 changed the title Fix pypi action to not use setup.py [BUGFIX] Fix pypi action to not use setup.py Oct 28, 2024
@misi9170 misi9170 added the bug Something isn't working label Oct 28, 2024
@misi9170
Copy link
Collaborator

I think we should point this at develop, and then do the normal develop -> main release afterwards. I could do that immediately, and then release v2.1.1, or we can leave it and bundle it with other patches before a 2.1.1 release. As it stands, v2.1 is now successfully available on PyPI (https://pypi.org/project/flasc/) and I've confirmed that I can install and access it via the usual pip install flasc.

@paulf81 paulf81 changed the base branch from main to develop October 28, 2024 19:28
@paulf81 paulf81 merged commit 0940c97 into NREL:develop Oct 28, 2024
3 checks passed
@paulf81 paulf81 mentioned this pull request Oct 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants