-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wind up example using FlascDataFrame
#210
Conversation
@aclerc I've merged back the flasc-dataframe target branch and resolved conflicts. Tests pass, and I checked that the examples_smarteole/09_wake_steering_uplift_analysis.ipynb notebook still runs and appears to produce the expected outputs. EDIT: perhaps not---I just ran the notebook again and get an error This remerging may need to happen one more time if we get #211 , which adds some core components to the |
Hi @misi9170 regarding |
Thanks @aclerc, that fixed it. I was using pandas 2.0.2 when I was having the problem, and upgrading to the current 2.2.2 solved the problem (I also had to upgrade pyarrow for compatibility with pandas 2.2.2). pandas 2.0.2 actually satisfies the current FLASC pandas requirement ( Confirming now that the notebook produces the expected 0.6%, -0.2%, 1.4% result. |
* Add new `FlascDataFrame` object to enhance user interface with data (#199) * Adding at the root level for now; could consider moving to utilities/ * Ruff. * precommit stuff. * Add example notebook * Add wide to long * Add test * Update README.md engagement * Update README.md replacing 'FLORIS' typo * Feature/add docstrings (#197) * Update to 15 (#202) * Update for PyPI installation. (#204) * Update version number; ignore version.py for ruff. * Adhere to FLASC formatting rules. * psuedocode for conversions. Tests for saving dataframe to file. * Print warning when to_feather used. * String formatting. * Add several more tests and n_turbines property. * Adding TODOs for long/wide conversions. * Clean up, a few more tests. * Improved printout. * ruff format. --------- Co-authored-by: Paul <[email protected]> Co-authored-by: christiannvaughn <[email protected]> * Add dataframe conversions to flascdataframe (#211) * Add wind up example using `FlascDataFrame` (#210) * loosen wind-up dependency * Finish FlascDataFrame (Paul) (#215) Add type hints * Finish FlascDataFrame (update examples/docs) (#219) * Merge recent changes. * Update functions to use FlascDataFrames; getter and setter for channel_name_map; metadata copying method. * Smarteole examples now using FlascDataFrame * Add brief demonstration of switch to user data format; rename 09 notebook for clarity. * Update artifical data examples. * Had weird behavior in the getter/setter caused by not providing the true underlying attribute in _metadata. * formatting. * Simplify imports of FlascDataFrame throughout. * Add wind-up to pyproject.toml after setup.py was removed. * Update docs for FlascDataFrame (#220) --------- Co-authored-by: misi9170 <[email protected]> Co-authored-by: christiannvaughn <[email protected]> Co-authored-by: Alex Clerc <[email protected]> Co-authored-by: misi9170 <[email protected]>
Feature or improvement description
Add a simple example of a wind-up uplift and uncertainty calculation
The filtered and northed flasc dataframe is converted to wind-up format using a new
FlascDataFrame
methodIt is probably best to merge PR #199 before merging this PR because I branched from
misi9170:feature/flasc-df
Related issue, if one exists
#195
Test results, if applicable
I have added
test_convert_to_windup_format()
which passes for me locally