Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify admin #246

Merged
merged 4 commits into from
Jun 3, 2016
Merged

Notify admin #246

merged 4 commits into from
Jun 3, 2016

Conversation

ThibautGery
Copy link
Contributor

@ThibautGery ThibautGery commented May 31, 2016

if the config send_notify_email is set to true then the signup of a new key send a mail to the administrator of Umbrella

NOTE :

  • I wasn't able to run the application and check the mail. Nonetheless the tests are green.
  • I don't know Rails so feedback is welcome

@GUI
Copy link
Member

GUI commented Jun 1, 2016

On a quick glance, this looks great! The test coverage also looks great, so thank for doing that. I'll look to get this merged into master tomorrow. Thanks for the contribution!

@GUI GUI merged commit bc2dbe2 into NREL:master Jun 3, 2016
@GUI
Copy link
Member

GUI commented Jun 3, 2016

Awesome, thanks for adding this feature!

@GUI GUI added this to the v0.12 milestone Jun 26, 2016
@GUI
Copy link
Member

GUI commented Jun 30, 2016

Quick heads up: v0.12.0 packages have been released, which includes this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants