This repository has been archived by the owner on Jan 7, 2018. It is now read-only.
Simpler query builder interface for constructing admin analytics queries #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the jQuery-QueryBuilder plugin to provide an easier query building interface for constructing analytics queries. This is intended to finally provide a nicer alternative to the raw "Advanced filters" query syntax, which is just a straight ElasticSearch query. I still need to figure out how the interface for this will fit in, but it basically seems to work.
Since we're now precompiling the assets during tests, we need to exclude this directory from Rubocop so it doesn't pick up files in there on subsequent runs.
Since we disabled jquery animations in b0383f8 this progress loader test began failing. I think this updated approach should be safe. While we're at it, update the jQuery BlockUI library. Also disable animations in non-test environments for BlockUI by default, since it doesn't really seem like we need the delays of fading in and out.
GUI
added a commit
that referenced
this pull request
Feb 20, 2015
Simpler query builder interface for constructing admin analytics queries
This was referenced Feb 20, 2015
GUI
added a commit
that referenced
this pull request
Jun 26, 2015
When we introduced the query builder interface for analytics (#7), it turns out we accidentally started making duplicate requests for the table data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current admin tool, if you wish to filter your analytics, you have to construct a query using Lucene's query syntax (which we pass along to ElasticSearch). This is powerful and flexible, but if you're not familiar with this syntax language or our internal field names, this isn't particularly friendly (especially when you get to URL paths and the need to escape slashes). Making an easier interface for people to filter the analytics has been on our todo list for forever.
This is an initial implementation of an easier query building interface. We're largely leveraging the jQuery QueryBuilder library to provide the UI for this. This provides drop down menus for picking which fields to filter on, the ability to choose conditions like "begins with", "contains", or "greater than", and then you can enter a search value (or choose from options for fields we know have a limited set of values). I've also added better inline help to describe each field. A screenshot probably best describes its functionality:
Hopefully this is a lot more intuitive for most people to use. The fields available for filtering in this UI isn't entirely complete (we store other fields internally), but I think this covers the main fields that 98% of queries are probably interested in. The old interface is also available if you click the "Switch to advanced filters" link, so if you're still keen on the raw ElasticSearch/Lucene queries, that functionality is still present and works just like before.