Skip to content
This repository has been archived by the owner on Jan 7, 2018. It is now read-only.

Commit

Permalink
Fix admin form checkboxes under Firefox.
Browse files Browse the repository at this point in the history
Firefox needed to detect this under the "change" event rather than the
"click" event (the click event was happening too early).

This would be a good reason to get some Selenium tests running so we
could run our test suite across real browsers, rather than just
webkit via phantomjs.
  • Loading branch information
GUI committed Aug 26, 2015
1 parent 45c9348 commit 015bb01
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/assets/javascripts/admin/views/checkbox_list_view.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Admin.CheckboxListItemView = Ember.Checkbox.extend({
return _.contains(checkedValues, value);
}.property('content', 'checkedValues.@each'),

click: function() {
change: function() {
var checkedValues = this.get('checkedValues') || [];
var value = this.get('content.id');

Expand Down

0 comments on commit 015bb01

Please sign in to comment.