This repository has been archived by the owner on Jan 7, 2018. It is now read-only.
Setup error data for easier overriding of URL variables. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now there's a concept of "common" error data variables, which we can use so that contact URLs (and other things like this) only have to be defined once per API backend, which makes it much easier to define variables only once which can then be embedded in other areas of the error response. See: 18F/api.data.gov#285 This also begins to cleanup and standardize the error data variables to snake_case moving forward (instead of some of our odd mixtures of camel-case that had built up over time).
Due to the order in which these were being looped over, if these variables contained other internal variables, the legacy copies weren't working properly (since they were bein modified later).
This was referenced Sep 19, 2015
GUI
added a commit
that referenced
this pull request
Oct 9, 2015
Setup error data for easier overriding of URL variables.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now there's a concept of "common" error data variables, which we can use so that contact URLs (and other things like this) only have to be defined once per API backend, which makes it much easier to define variables only once which can then be embedded in other areas of the error response.
See: 18F/api.data.gov#285
This also begins to cleanup and standardize the error data variables to snake_case moving forward (instead of some of our odd mixtures of camel-case that had built up over time).