-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding powercurve actuator method #115
Open
cfrontin
wants to merge
68
commits into
NREL:dev
Choose a base branch
from
cfrontin:dev-powercurve
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated power and funky derivitives w.r.t. rated power and rated thrust.
… just rated power control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR integrates the actuator disk method with power curves enabled.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
I've run some stuff verifying that an isolated turbine recreates the theoretical powercurve (i.e. P=Prated above Vrated, CP-maximization at the lowest range, power limited s.t. T=Tmax in thrust shaving region, etc.)
We should probably make a formal test of this behavior!
I think we probably should add smooth cutoff emulation as well?
Checklist
Put an
x
in the boxes that apply.