Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding powercurve actuator method #115

Open
wants to merge 68 commits into
base: dev
Choose a base branch
from

Conversation

cfrontin
Copy link

Purpose

This PR integrates the actuator disk method with power curves enabled.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I've run some stuff verifying that an isolated turbine recreates the theoretical powercurve (i.e. P=Prated above Vrated, CP-maximization at the lowest range, power limited s.t. T=Tmax in thrust shaving region, etc.)

We should probably make a formal test of this behavior!

I think we probably should add smooth cutoff emulation as well?

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have verified my code additions work in parallel
  • I have added necessary documentation

jefalon and others added 30 commits March 25, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants