Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional gmsh integration for rectangles and boxes. #112

Merged
merged 36 commits into from
Mar 27, 2024
Merged

Conversation

cfrontin
Copy link

@cfrontin cfrontin commented Dec 15, 2023

Purpose

Adds optional gmsh-based recreation of default box and rectangle grids.

  • adds new enum case for yaml input mesh_type: gmsh; when specified gmsh grids are used
  • grid stretching is toggled by hardcoded param, probably should be made an input
    • runs gmsh on stretched box to get an isotropic unstructured grid
    • relaxes stretching of box to get unstructured grid with specified aspect ratios
  • my VS code automatically killed some trailing whitespace also, so that's in the commit too. fwiw adding ?w=1 to comparison URLs on GH ignores whitespace-only changes in the diff

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • New feature (non-breaking change which adds functionality)

Testing

  • add new test case(s) to tests/9_Regression?

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have verified my code additions work in parallel
  • I have added necessary documentation
  • I have made sure the GPL virality concerns are not an issue for incorporation into NREL WindSE

@eyoung55 eyoung55 self-assigned this Jan 5, 2024
@cfrontin
Copy link
Author

sorry if i stepped on your toes! i didnt mean to push my fix-it commit.

@jefalon
Copy link
Collaborator

jefalon commented Jan 26, 2024

lol, No worries, I wasn't working particularly fast. I was having problems getting the demos to run correctly. I think it's fixed. Hopefully it passes CI (though it seems stuck on the parallel case)

@cfrontin
Copy link
Author

cfrontin commented Feb 26, 2024

Hmm, from my memory related investigations, I think that the mesh will be meshed (hopefully identically) on every single processor. I think some kind of "rank == 0" operation should happen on this line and the others like it... I think also we'd have to get the variable called dir_to_meshes to be shared across the other ranks so that dummy.xml can be accessed by all processes once it's done? the thing is i know nothing about is how to deal with this in a fenics-friendly way @eyoung55 and @jefalon

@jefalon jefalon merged commit b509619 into NREL:dev Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants