Issue18 a flo attributes

[kbenne]

No description provided.

[mwetter]

This change needs to be applied to all parameters, not only to AFlo.
In addition, it also needs to be applied to the surface object.
See https://lbl-srg.github.io/soep/softwareArchitecture.html for the list of parameters.

[kbenne]

I have been thinking about restructuring the code related to I/O variables, probably with a class hierarchy of some kind. The current design is a bit brutalist. However, such ambition is not in the cards right now, so I'm just correcting issues based on the current implantation.

Since this is becoming more of a comprehensive review of the FMU metadata I'm just going to consolidate on this one branch and corresponding PR. In that spirit, #17, is contained in this PR so I'm going to close #17. Future commits of FMU metadata will be included in this PR also, until it is right.

[mwetter]

The code around

Spawn/lib/variables.cpp

Line 130 in 44a1417

var.real_attributes.emplace_back("start","0.0");

seems to be inconsistent with

        var.type = VariableType::TSURF;
        var.name = surface.idfname;
        var.epunittype = spawn::units::UnitType::C;
        var.mounittype = spawn::units::UnitType::K;

        var.scalar_attributes.emplace_back("name",surface.idfname + "_T");
        var.scalar_attributes.emplace_back("valueReference", std::to_string(i));
        var.scalar_attributes.emplace_back("description","Temperature of the surface");
        var.scalar_attributes.emplace_back("causality","input");
        var.scalar_attributes.emplace_back("variability","continuous");

        var.real_attributes.emplace_back("quantity","ThermodynamicTemperature");
        var.real_attributes.emplace_back("relativeQuantity","false");
        var.real_attributes.emplace_back("start","0.0");
        var.real_attributes.emplace_back("unit",spawn::units::toString(var.mounittype));
        var.setValue(21.0, spawn::units::UnitSystem::EP);

        result.emplace(i,std::move(var));

which sets the value to 21.

Otherwise it looks good.