Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 2024 resstock data #1915

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Updates for 2024 resstock data #1915

wants to merge 1 commit into from

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Nov 18, 2024

Pull Request Template

Description

Updates to get.py that allow it the example script to work with 2024 resstock data. Haven't tested other EULP releases.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@brtietz brtietz added this to the SAM Fall 2024 Release milestone Nov 18, 2024
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

There are two other places that check for year = 2021 like this:

if year is 2021
    do 2021 things
else
    do other year things

A fix more consistent with the rest of the code would be

    if year == '2021':
        wf_folder = f'{wf_type}'
    else:
        wf_folder = f'state={state}'

Thanks,
Paul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants