Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom-tables #596

Merged
merged 46 commits into from
Sep 27, 2024
Merged

Custom-tables #596

merged 46 commits into from
Sep 27, 2024

Conversation

bpulluta
Copy link
Collaborator

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

  • Added a new functionality to generate a custom comparison table based on multiple run_uuid inputs.
  • Introduced a new URL pattern to support multiple UUIDs in the URL, separated by semicolons.
  • The create_custom_comparison_table view now processes multiple UUIDs and returns an Excel file as output.

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)

Other information:

  • This change enhances the REopt API by allowing users to compare multiple scenarios in a single Excel output.
  • The URL pattern for the comparison table has been updated to handle multiple UUIDs, ensuring backward compatibility with previous URL patterns.

@Bill-Becker
Copy link
Collaborator

@bpulluta could you add an example way (or add functionality if it doesn't exist) to do the following (maybe in the "dummy" other_custom_table, which can be used as a sort of "template" to build a new custom table) :

  1. Calculate a value for a row in the BAU column that is different from the way the other optimal columns are calculated? I.e. if we need to reference an input value for the BAU column, but an output for all the optimal scenarios
  2. Do some math on multiple outputs (or inputs/outputs) and then use that value for the row
  3. Hard code a value that we want to put in the cell, even if we know it's not coming from a REopt output or input
  4. Format a selected row in a certain way, including either background/font or formatting the value like a % versus a float.

Again, amazing work to get this far of getting what I requested for the TASC. At this point, my requests are for expanding on the basic capability to make it extensible and easier to customize other tables which will be super helpful in the future too.

@Bill-Becker Bill-Becker removed the request for review from rathod-b September 27, 2024 16:38
@Bill-Becker Bill-Becker merged commit 75eca34 into develop Sep 27, 2024
2 checks passed
@Bill-Becker Bill-Becker deleted the custom-tables branch September 27, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants