-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary endpoint revision and updates #584
Conversation
Provide summary data for given run_uuids
change key name per feedback
add missing fields
update filter to properly exclude portfolio associated runs
Hi @Bill-Becker , we have two questions on this PR:
|
|
Sounds good on point 1. On point 2, i was referring to portfolio runs which have been executed since portfolio runs were made available in the API/webtool production and the day we deploy this feature branch. Those portfolio runs at present dont have a portfolio_uuid and should be assigned one for proper filtering in Django. So we may need a script for this. |
Ah, yes, so we'll have to create and add the portfolio_uuid to those previously-run portfolios. Makes sense you'd need to do this, unless the web tool can preserve the way it currently has those attached to the user's profile and just update to the new endpoint (if we are preserving the old endpoint) for the new portfolios. If not, yes we'll have to assign those a portfolio_uuid. |
Add resilience focus, outage duration
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
Features
What is the current behavior?
(You can also link to an open issue here)
run
cannot be marked separate from aportfolio
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
No changes to the users, they should notice a speedup on Past Evaluations page
Other information:
Changes have been tested on the front end in staging environment, no tests were added.