-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disaggregated heat load inputs and outputs + Process heat load #583
Conversation
@zolanaj just making sure this won't affect any existing behavior when using the default |
Confirmed, the defaults for CHP, ExistingBoiler, HotThermalStorage, Boiler, and SteamTurbine can all serve both DHW and space heating by default, which is consistent with the notion that all techs serve all heating loads. The exception is GHP which already had the field HeatingLoad outputs for DHW and SpaceHeating are unchanged. There are new outputs within HeatingLoad related to process heat, but only if included (otherwise it's blank). Will that work or should those be suppressed somehow? |
reoptjl/models.py
Outdated
@@ -6420,6 +6693,12 @@ class AbsorptionChillerInputs(BaseModel, models.Model): | |||
'hot_water' | |||
)) | |||
|
|||
HEATING_LOAD_INPUT = models.TextChoices('HEATING_LOAD_INPUT', ( | |||
'DomesitHotWater', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this spelling in abf56a1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and the changelog update!
reoptjl/models.py
Outdated
@@ -6193,6 +6371,55 @@ def clean(self): | |||
if self.addressable_load_fraction == None: | |||
self.addressable_load_fraction = list([1.0]) # should not convert to timeseries, in case it is to be used with monthly_mmbtu or annual_mmbtu | |||
|
|||
class ProcessHeatLoadInputs(BaseModel, models.Model): | |||
# DHW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "#DHW" here intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not! Updated it here - d7d6652
julia_src/Manifest.toml
Outdated
uuid = "d36ad4e8-d74a-4f7a-ace1-eaea049febf6" | ||
version = "0.45.0" | ||
version = "0.46.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note to update this to the 46.1 eventually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder! Addressed here: ae8fcea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one very minor comment :)
@zolanaj thanks for confirming, that should work. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
None known, but the new I/O requires linkage to v. 0.46.1 of REopt.jl
Other information: