Pv tilt update

CHANGELOG.md

@@ -26,6 +26,11 @@ Classify the change according to the following categories:
     ##### Removed
     ### Patches
 
+## Develop - 2024-04-19
+### Minor Updates
+#### Changed
+- In `core/pv.jl` a change was made to make sure we are using the same assumptions as PVWatts guidelines, the default `tilt` angle for a fixed array should be 20 degrees, irrespective of it being a rooftop `(0)` or ground-mounted (open-rack)`(1)` system. By default the `tilt` will be set to 20 degrees for fixed ground-mount and rooftop, and 0 degrees for axis-tracking (`array_type = (2), (3), or (4)`)
+
 ## v3.7.0
 ### Minor Updates
 #### Changed

reoptjl/migrations/0057_alter_pvinputs_tilt.py

@@ -0,0 +1,19 @@
+# Generated by Django 4.0.7 on 2024-04-23 17:45
+
+import django.core.validators
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('reoptjl', '0056_alter_electricloadinputs_annual_kwh_and_more'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='pvinputs',
+            name='tilt',
+            field=models.FloatField(blank=True, help_text='PV system tilt: Set tilt angle to 20 degrees for fixed arrays (rooftop or ground-mounted). Set tilt angle to 0 degrees for axis-tracking systems.', null=True, validators=[django.core.validators.MinValueValidator(0), django.core.validators.MaxValueValidator(90)]),
+        ),
+    ]

reoptjl/models.py

@@ -2790,7 +2790,7 @@ class PV_LOCATION_CHOICES(models.TextChoices):
         ],
         blank=True,
         null=True,
-        help_text="PV system tilt. If PV system type is rooftop-fixed, then tilt=10 degrees, else tilt=20 degrees"
+        help_text="PV system tilt: Set tilt angle to 20 degrees for fixed arrays (rooftop or ground-mounted). Set tilt angle to 0 degrees for axis-tracking systems."
     )
     location = models.TextField(
         default=PV_LOCATION_CHOICES.BOTH,

reoptjl/test/test_validator.py

@@ -314,16 +314,15 @@ def test_pv_tilt_defaults(self):
         validator.clean_fields()
         validator.clean()
         validator.cross_clean()
-        self.assertEquals(validator.models["PV"].tilt, 10)
+        self.assertEquals(validator.models["PV"].tilt, 20)
 
         post["APIMeta"]["run_uuid"] = uuid.uuid4()
-        post["PV"]["array_type"] = 0
+        post["PV"]["array_type"] = 2
         validator = InputValidator(post)
         validator.clean_fields()
         validator.clean()
         validator.cross_clean()
-        self.assertAlmostEquals(validator.models["PV"].tilt, 20)
-
+        self.assertAlmostEquals(validator.models["PV"].tilt, 0)
 
     def boiler_validation(self):
         """

reoptjl/validators.py

@@ -203,12 +203,14 @@ def cross_clean(self):
         """
         PV validation
         """
-        def cross_clean_pv(pvmodel):
-            if pvmodel.__getattribute__("tilt") == None:
-                if pvmodel.__getattribute__("array_type") == pvmodel.ARRAY_TYPE_CHOICES.ROOFTOP_FIXED:
-                    pvmodel.__setattr__("tilt", 10)
-                else:
+        def cross_clean_pv(pvmodel):     
+            if pvmodel.__getattribute__("tilt") is None:
+                if pvmodel.__getattribute__("array_type") in (pvmodel.ARRAY_TYPE_CHOICES.GROUND_MOUNT_FIXED_OPEN_RACK, 
+                                                            pvmodel.ARRAY_TYPE_CHOICES.ROOFTOP_FIXED):
                     pvmodel.__setattr__("tilt", 20)
+                else:
+                    pvmodel.__setattr__("tilt", 0)
+
 
             if pvmodel.__getattribute__("azimuth") == None:
                 if self.models["Site"].__getattribute__("latitude") >= 0: