Hot fix: Fuel loads profile input #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, if needed Apply to SpaceHeatingLoad, DomesticHotWaterLoad, and Cooling Load This not only makes the code more DRY, but it also fixes a bug where the validation was requiring a building even when an hourly load profile was input (not relying on a CRB).
Fuel loads profile input fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #469.
Fixes validation bug and improves DRY.
Validation bug:
If a user input a SpaceHeatingLoad or DomesticHotWaterLoad input of fuel_loads_mmbtu_per_hour, which should not require a doe_reference_name, the validator was checking for and requiring a doe_reference_name to be there too.