ERP BESS SOC discretization improvement; peak_load_outage_times bug fix #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdunham
changed the title
Bill-Becker
approved these changes
Jun 20, 2023
This reverts commit 5e35e03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
ERPElectricStorageInputsnum_battery_bins defaults to 100 and has no maxTime step values returned from peak_load_outage_times endpoint are 0-indexed
peak_load_outage_times endpoint can return time steps less than 1 when outages centered on peak
What is the new behavior (if this is a feature change)?
ERPElectricStorageInputsnum_battery_bins defaults to 20 * size_kwh / self.size_kw and has max of 2000Make time step values returned from peak_load_outage_times endpoint 1-indexed
Don't let peak_load_outage_times endpoint return a time step less than 1
Does this PR introduce a breaking change?
no
Other information: