Add code to job/ app to accept Hot & Cold Thermal Storage #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolanaj
changed the title
|
@Bill-Becker this PR adds both hot and cold TES functionality to the API. I added TES to the new test we added for the CoolingLoad PR. Let me know if you have any questions - thanks! |
Bill-Becker
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
This all looks good to me, thanks! There is an open PR that adds a test for all inputs of the API to check for consistency with REopt.jl, so all new inputs should be added to that. I know that a lot of other inputs have been added without being added to that, so maybe it's fine to leave off these new inputs off for now and we'll have to go through after that PR passes and add everything.
|
Thanks @Bill-Becker! I'll make a note of this but given there are other inputs to be merged, I won't add an issue right now. |
This was referenced Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Update job/ app to include HotThermalStorage, ColdThermalStorage code
Addresses issue #298 and issue #373