Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.47.2 #419

Merged
merged 37 commits into from
Jul 5, 2024
Merged

v0.47.2 #419

merged 37 commits into from
Jul 5, 2024

Conversation

zolanaj
Copy link
Collaborator

@zolanaj zolanaj commented Jul 3, 2024 •
edited
Loading

zolanaj and others added 30 commits May 22, 2024 13:33
@zolanaj
update bounds on wholesale, net metering benefits benefits
d1a682f
@zolanaj
Merge branch 'develop' into fix-net-metering-and-demand-charges
5fd6399
@zolanaj
obtain tier limits before scrubbing demand rate structures
f8ea5e6
@zolanaj
new testset Multi-tier demand rates
bd6acbc
@zolanaj
update NM test value
3a80c9c
@zolanaj
Update CHANGELOG.md
8637d62
@zolanaj
reduce very large hand-entered numbers for maxes to bigM
abc269d
@zolanaj
Update CHANGELOG.md
209ba63
@zolanaj
Merge branch 'develop' into fix-net-metering-and-demand-charges
a42073a
@zolanaj
use minimums for individual tier limits when more than one set of tie…
3d623f0 
…r limits is provided
@zolanaj
increase energy tier limit
0c5207f
@zolanaj
go back to general parse_urdb_demand_tiers using an array instead of …
fff3597 
…Dict
@zolanaj
simplify parse_urdb_demand_tiers
a91872a
@zolanaj
get limits directly from demand parsers
25c5c51
@zolanaj
ren parse_urdb_demand_tiers get_num_demand_tiers
32dfaaa
@zolanaj
make monthly_demand_tier_limits, tou_demand_tier_limits 2-dimensional…
447f9ab 
… arrays
@zolanaj
update indexing of p.s.electric_tariff.tou_demand_tier_limits, p.s.el…
60ed541 
…ectric_tariff.monthly_demand_tier_limits
@zolanaj
index tier limits on month or TOU period
3091f0e
@zolanaj
ren scrub_urdb_demand_tiers scrub_urdb_tiers
56ff653
@zolanaj
ren get_num_demand_tiers get_num_tiers
238b951
@zolanaj
update warning for scrub_urdb_tiers
2398e8b
@zolanaj
make energy limits 2-dimensional array instead of vector
8502b1c
@zolanaj
expand mulitple tier testing
28d8917
@adfarth
Merge branch 'develop' into fix-net-metering-and-demand-charges
202145c
@adfarth
changelog, add notes
b53f9e4
@Bill-Becker
Add thermal efficiency as input to chp defaults function
e8c285b 
To allow heuristic sizing with overrides to zero thermal efficiency defaults, e.g. for microturbine
@zolanaj
rm comment on URDB Dict modification from parsing function docstrings
226cd67
@zolanaj
refactoring to remove get_num_tiers()
5fbc355
@zolanaj
add notes for dimension of tier limits
f1301b2
@zolanaj
Update CHANGELOG.md
ccfcb51
@zolanaj zolanaj requested a review from adfarth July 3, 2024 19:12
adfarth
adfarth approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zolanaj Approving pending the macOS tests passing! Just to double check, are any changes in the API required other than updating the REopt version #?

@Bill-Becker
Copy link
Collaborator

@adfarth @zolanaj Since the windows test passed, we can ignore waiting for Mac. Alex - I'd really like to get another PR in there for an IEDO-requested fix: #415, if you don't mind reviewing that quickly.

@zolanaj
Copy link
Collaborator Author

zolanaj commented Jul 5, 2024

@adfarth @zolanaj Since the windows test passed, we can ignore waiting for Mac. Alex - I'd really like to get another PR in there for an IEDO-requested fix: #415, if you don't mind reviewing that quickly.

@Bill-Becker review completed, and after the minor comment is addressed I can merge and register the new version.

@Bill-Becker
Copy link
Collaborator

@adfarth @zolanaj Since the windows test passed, we can ignore waiting for Mac. Alex - I'd really like to get another PR in there for an IEDO-requested fix: #415, if you don't mind reviewing that quickly.

@Bill-Becker review completed, and after the minor comment is addressed I can merge and register the new version.

@zolanaj thanks for the quick review - let me know if my response on that PR addresses your comment.

@zolanaj
Merge pull request #415 from NREL/mt-therm-effic
53b92bf 
Hot Fix: Add thermal efficiency as input to chp defaults function
@zolanaj
Update CHANGELOG.md
4ba2d47
@Bill-Becker
Copy link
Collaborator

@zolanaj thanks for merging the other PR, and for adding the CHANGELOG line. I approve this PR as well!

@zolanaj zolanaj merged commit ac70848 into master Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adfarth adfarth adfarth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zolanaj @Bill-Becker @brtietz @adfarth