Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rate adjustments #352

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Fix rate adjustments #352

merged 5 commits into from
Mar 8, 2024

Conversation

adfarth
Copy link
Collaborator

@adfarth adfarth commented Feb 27, 2024 •
edited
Loading

  • Previously, whl_rate length was getting set to length(energy_rates[:,1]) * time_steps_per_hour. However, energy_rates is already adjusted for time_steps_per_hour, so the whl_rate was getting double-adjusted (e.g., set to length 8760x4x4)
  • The attached post was therefore erroring, but should now work.
    reopt-error-dimensionmismatch.json

@adfarth adfarth marked this pull request as ready for review March 8, 2024 16:31
@adfarth adfarth requested a review from Bill-Becker March 8, 2024 20:10
@adfarth adfarth merged commit d6cb4cd into develop Mar 8, 2024
4 checks passed
@adfarth adfarth deleted the rate-fix branch March 8, 2024 21:39
@adfarth adfarth mentioned this pull request Mar 8, 2024
Merged
indu-manogaran pushed a commit that referenced this pull request Sep 16, 2024
@adfarth @indu-manogaran
Merge pull request #352 from NREL/rate-fix
17cd826 
Fix rate adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bill-Becker Bill-Becker Bill-Becker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adfarth @Bill-Becker