Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve indexing robustness #346

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Improve indexing robustness #346

merged 7 commits into from
Apr 18, 2024

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Jan 29, 2024

Fixed

  • Changed instances of indexing using i in 1:length() paradigm to use eachindex() or axes() instead because this is more robust
  • In src/core/urdb.jl, ensure values from the "energyweekdayschedule" and "energyweekendschedule" arrays in the URDB response dictionary are converted to Int before being used as indices

@hdunham hdunham merged commit 3762d7a into develop Apr 18, 2024
3 of 4 checks passed
@hdunham hdunham deleted the indexing-robustness branch April 18, 2024 20:30
@hdunham hdunham mentioned this pull request Apr 18, 2024
indu-manogaran pushed a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants