ERP CHP fuel HHV bug #325
Merged
ERP CHP fuel HHV bug #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bill-Becker
force-pushed
the
erp-chp-fuel-bug
branch
from
f1d0c2d
to
ae9dc2d
Compare
Bill-Becker
force-pushed
the
erp-chp-fuel-bug
branch
from
ae9dc2d
to
1ba1227
Compare
Bill-Becker
reviewed
Apr 11, 2024
| @@ -95,10 +95,10 @@ end | |||
|
|
|||
|
|
|||
| function add_MG_Gen_fuel_burn_constraints(m,p) | |||
| fuel_slope_gal_per_kwhe, fuel_intercept_gal_per_hr = generator_fuel_slope_and_intercept( | |||
| fuel_slope_gal_per_kwhe, fuel_intercept_gal_per_hr = fuel_slope_and_intercept( | |||
There was a problem hiding this comment.
Should we do this for CHP fuel burn below as well?
There was a problem hiding this comment.
Yeah sure! Added it in two more places to eliminate dupe code
| @@ -27,6 +27,9 @@ Classify the change according to the following categories: | |||
| ### Fixed | |||
| - Added `export_rate_beyond_net_metering_limit` to list of inputs to be converted to type Real, to avoid MethodError if type is vector of Any. | |||
| - Fix blended CRB processing when one or more load types have zero annual energy | |||
| - When calculating CHP fuel intercept and slope, use 1 for the HHV because CHP fuel measured in units of kWh, instead of using non-existent **CHP.fuel_higher_heating_value_kwh_per_gal** | |||
There was a problem hiding this comment.
Where was this implemented?
There was a problem hiding this comment.
REopt.jl/src/outagesim/backup_reliability.jl
Line 803 in 54dbb3f
Bill-Becker
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Changed
generator_fuel_slope_and_intercepttofuel_slope_and_interceptand generalize to not be specific to diesel measured in units of gal