Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup the python bindings workflow, add python 3.13 for windows, and use os.add_dll_directory for windows #5288

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Fixup the python bindings workflow, add python 3.13 for windows, and use os.add_dll_directory for windows #5288

merged 8 commits into from
Nov 13, 2024

Commits on Nov 12, 2024

  1. Bump python bindings action: add windows py313, bump macos to 12 (wil… 

    …l be removed in december) and use ubuntu 22.04
    @jmarrec
    jmarrec committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d7f7e42 View commit details
    Browse the repository at this point in the history

  2. my forked setup-python doesn't work for windows py313 because it's no… 

    …t in the image cache

also -Wno-enum-constexpr-conversion isn't understand on older apple clang
    @jmarrec
    jmarrec committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2b8be92 View commit details
    Browse the repository at this point in the history

  3. Try with a ternary like operator 

    I'm referencing the id of that step...

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#example
    @jmarrec
    jmarrec committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b31e02c View commit details
    Browse the repository at this point in the history

  4. Use a different step id

    @jmarrec
    jmarrec committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0e3cc37 View commit details
    Browse the repository at this point in the history

  5. use os.add_dll_directory for windows when using the **installed** Pyt… 

    …hon/ folder with system python

https://docs.python.org/3/library/os.html#os.add_dll_directory
    @jmarrec
    jmarrec committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f2ce25b View commit details
    Browse the repository at this point in the history

  6. Py_SetPath removed from Python 3.13. We should upgrade to use PyConfi… 

    …g, but too late in the release cycle
    @jmarrec
    jmarrec committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ad5f550 View commit details
    Browse the repository at this point in the history

  7. Why is testpypi upload failing? Try with --verbose

    @jmarrec
    jmarrec committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    76e2246 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Drop support for python bindings on Ubuntu 20.04, update mac runner, … 

    …add test for py313
    @jmarrec
    jmarrec committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4958299 View commit details
    Browse the repository at this point in the history