Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap Coil:Cooling:DX:SingleSpeed:ThermalStorage #5059

Merged
merged 61 commits into from
Mar 27, 2024
Merged

Wrap Coil:Cooling:DX:SingleSpeed:ThermalStorage #5059

merged 61 commits into from
Mar 27, 2024

Commits on Dec 8, 2023

  1. Add new thermal storage cooling coil object to idd.

    @joseph-robertson
    joseph-robertson committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    158ae72 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Add src model files from GenerateClass.rb.

    @joseph-robertson
    joseph-robertson committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    e2bd5fe View commit details
    Browse the repository at this point in the history

  2. Add src ft files from GenerateClass.rb.

    @joseph-robertson
    joseph-robertson committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    114364e View commit details
    Browse the repository at this point in the history

  3. Formatting.

    @joseph-robertson
    joseph-robertson committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    02246c8 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Update schedule type registry cpp.

    @joseph-robertson
    joseph-robertson committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    610bb1a View commit details
    Browse the repository at this point in the history

  2. Formatting.

    @joseph-robertson
    joseph-robertson committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    91b8a6b View commit details
    Browse the repository at this point in the history

  3. Update condenser air node fields in idd.

    @joseph-robertson
    joseph-robertson committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    07388cc View commit details
    Browse the repository at this point in the history

  4. Start to update the ctor.

    @joseph-robertson
    joseph-robertson committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    abd85d1 View commit details
    Browse the repository at this point in the history

  5. Formatting.

    @joseph-robertson
    joseph-robertson committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    bb11cf9 View commit details
    Browse the repository at this point in the history

  6. Start adding curves to ctor.

    @joseph-robertson
    joseph-robertson committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    863ffa2 View commit details
    Browse the repository at this point in the history

  7. Formatting.

    @joseph-robertson
    joseph-robertson committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0686a69 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Change all xxxFunctions to Curve.

    @joseph-robertson
    joseph-robertson committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    778534f View commit details
    Browse the repository at this point in the history

  2. Stub validity check in FT for required curves with modes.

    @joseph-robertson
    joseph-robertson committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    957e301 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Missing required field in idd.

    @joseph-robertson
    joseph-robertson committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e70af23 View commit details
    Browse the repository at this point in the history

  2. Add convenience ctor exposing modes available.

    @joseph-robertson
    joseph-robertson committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    5184eac View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Clean up ft test.

    @joseph-robertson
    joseph-robertson committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    5543a5e View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Merge branch 'develop' into coil-thermal-storage

    @joseph-robertson
    joseph-robertson committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2340337 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge branch 'develop' into coil-thermal-storage

    @joseph-robertson
    joseph-robertson committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    61fcc1b View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Clean up model files.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    41d8b04 View commit details
    Browse the repository at this point in the history

  2. Clean up ft file.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c198e7f View commit details
    Browse the repository at this point in the history

  3. Formatting.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a54dfea View commit details
    Browse the repository at this point in the history

  4. Continue cleaning up model and ft files.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    69cf4e4 View commit details
    Browse the repository at this point in the history

  5. Start to clean up model and ft test files.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    da394f3 View commit details
    Browse the repository at this point in the history

  6. Split ft into with and without unitary.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2579778 View commit details
    Browse the repository at this point in the history

  7. Include thermal storage in cmakelists, model files, etc.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d662b91 View commit details
    Browse the repository at this point in the history

  8. Formatting.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d74423a View commit details
    Browse the repository at this point in the history

  9. Update idd and methods for storage types.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9e3448a View commit details
    Browse the repository at this point in the history

  10. Stub out virtual methods.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1a8054c View commit details
    Browse the repository at this point in the history

  11. Comment out all methods related to water storage tanks.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6776402 View commit details
    Browse the repository at this point in the history

  12. Missed one.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    63d0f84 View commit details
    Browse the repository at this point in the history

  13. Change nodes to alphas.

    @joseph-robertson
    joseph-robertson committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    008a933 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Update model cpp so it builds.

    @joseph-robertson
    joseph-robertson committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7a04dd1 View commit details
    Browse the repository at this point in the history

  2. Update model and ft tests, and get things building.

    @joseph-robertson
    joseph-robertson committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2fc2cf2 View commit details
    Browse the repository at this point in the history

  3. Formatting.

    @joseph-robertson
    joseph-robertson committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5f49797 View commit details
    Browse the repository at this point in the history

  4. Update ft of new coil parent objects.

    @joseph-robertson
    joseph-robertson committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    621e58c View commit details
    Browse the repository at this point in the history

  5. Update ft and tests; currently passing.

    @joseph-robertson
    joseph-robertson committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4f49388 View commit details
    Browse the repository at this point in the history

  6. Remove extra assert.

    @joseph-robertson
    joseph-robertson committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    027f7e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Change all autocalculated to autosized.

    @joseph-robertson
    joseph-robertson committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0e7b34d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'develop' into coil-thermal-storage

    @joseph-robertson
    joseph-robertson committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a286a32 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Respond to review with idd updates and ft fixes.

    @joseph-robertson
    joseph-robertson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ec02646 View commit details
    Browse the repository at this point in the history

  2. Set to ScheduledModes in ctor.

    @joseph-robertson
    joseph-robertson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4a0569f View commit details
    Browse the repository at this point in the history

  3. Update ft includes.

    @joseph-robertson
    joseph-robertson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    da9da35 View commit details
    Browse the repository at this point in the history

  4. Update model and ft tests.

    @joseph-robertson
    joseph-robertson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    049c99c View commit details
    Browse the repository at this point in the history

  5. Typo.

    @joseph-robertson
    joseph-robertson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2aac063 View commit details
    Browse the repository at this point in the history

  6. Another typo.

    @joseph-robertson
    joseph-robertson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    25d6de8 View commit details
    Browse the repository at this point in the history

  7. Another include.

    @joseph-robertson
    joseph-robertson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6f2fd81 View commit details
    Browse the repository at this point in the history

  8. Update methods around glycol concentration.

    @joseph-robertson
    joseph-robertson committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4b454b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. More required fields in idd and reset method removals.

    @joseph-robertson
    joseph-robertson committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    728566e View commit details
    Browse the repository at this point in the history

  2. Fix cpp and start adding ft parent system tests.

    @joseph-robertson
    joseph-robertson committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    3f71ca7 View commit details
    Browse the repository at this point in the history

  3. Updates and fixes for containing hvac.

    @joseph-robertson
    joseph-robertson committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    545e093 View commit details
    Browse the repository at this point in the history

  4. Update addToNode.

    @joseph-robertson
    joseph-robertson committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    13cfe58 View commit details
    Browse the repository at this point in the history

  5. Fix a couple typos in ft test.

    @joseph-robertson
    joseph-robertson committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    aab11b6 View commit details
    Browse the repository at this point in the history

  6. Avoid overriding availability schedule in an ft test.

    @joseph-robertson
    joseph-robertson committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    df48009 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Revert ft changes on components that cannot have the new coil.

    @joseph-robertson
    joseph-robertson committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    5d5171d View commit details
    Browse the repository at this point in the history

  2. Format the list of output variables.

    @joseph-robertson
    joseph-robertson committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    662edba View commit details
    Browse the repository at this point in the history

  3. Update idd, remove overrides, extra clone and remove model tests.

    @joseph-robertson
    joseph-robertson committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    060f040 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Fix up new model tests.

    @joseph-robertson
    joseph-robertson committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    69274c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge branch 'develop' into coil-thermal-storage

    @jmarrec
    jmarrec authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8d78cd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge branch 'develop' into coil-thermal-storage

    @joseph-robertson
    joseph-robertson committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9eaa096 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Update model test expects for remove.

    @joseph-robertson
    joseph-robertson committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0123337 View commit details
    Browse the repository at this point in the history

  2. Override children with all curves.

    @joseph-robertson
    joseph-robertson committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    faffcfd View commit details
    Browse the repository at this point in the history