Add missing add_result_measure_info so that out.osw step result have the same info as before
#5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found because the OS-resources tests rely on it to locate openstudio_results
jmarrec
added
component - Workflow
Pull Request - Ready for CI
jmarrec
commented
Nov 15, 2023
Comment on lines
+332
to
+350
| bool addResultMeasureInfo(WorkflowStepResult& result, BCLMeasure& measure) { | ||
| try { | ||
| result.setMeasureType(measure.measureType()); | ||
| result.setMeasureName(measure.name()); | ||
| result.setMeasureId(measure.uid()); | ||
| result.setMeasureVersionId(measure.versionId()); | ||
| auto version_modified_ = measure.versionModified(); | ||
| if (version_modified_) { | ||
| result.setMeasureVersionModified(*version_modified_); | ||
| } | ||
| result.setMeasureXmlChecksum(measure.xmlChecksum()); | ||
| result.setMeasureClassName(measure.className()); | ||
| result.setMeasureDisplayName(measure.displayName()); | ||
| result.setMeasureTaxonomy(measure.taxonomyTag()); | ||
| return true; | ||
| } catch (...) { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
| @@ -84,6 +84,7 @@ void OSWorkflow::applyMeasures(MeasureType measureType, bool energyplus_output_r | |||
| LOG(Info, fmt::format("Skipping measure '{}'", measureDirName)); | |||
| WorkflowStepResult result = runner.result(); | |||
| runner.incrementStep(); | |||
| // addResultMeasureInfo(result, bclMeasure); // TODO: Should I really instantiate the BCLMeasure just for this? | |||
There was a problem hiding this comment.
When Skip, I'm not doing it. I think that's fine.
There was a problem hiding this comment.
New test before/after
|
CI Results for ad85c1a:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Found because the OS-resources tests rely on it to locate openstudio_results
Left is 3.6.1, Right is the C++ CLI:
After: same
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.