Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoilerHotWater: on cycle name change #4985

Merged
merged 6 commits into from
Sep 27, 2023
Merged

BoilerHotWater: on cycle name change #4985

merged 6 commits into from
Sep 27, 2023

Conversation

joseph-robertson
Copy link
Collaborator

Pull request overview

  • "Parasitic Electric Load" -> "On Cycle Parasitic Electric Load":
    • Boiler:HotWater

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Sep 27, 2023
@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.7.0 milestone Sep 27, 2023
@joseph-robertson joseph-robertson self-assigned this Sep 27, 2023
jmarrec
jmarrec requested changes Sep 27, 2023
View reviewed changes
src/energyplus/ForwardTranslator/ForwardTranslateBoilerHotWater.cpp Outdated Show resolved Hide resolved
src/model/BoilerHotWater.cpp Outdated Show resolved Hide resolved
@joseph-robertson joseph-robertson mentioned this pull request Sep 27, 2023
Closed
26 tasks
jmarrec
jmarrec approved these changes Sep 27, 2023
View reviewed changes
resources/model/OpenStudio.idd
@@ -13732,7 +13732,7 @@ OS:Boiler:HotWater,
\units W
\ip-units W
\minimum 0.0
\default 0.0
\required-field
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

src/energyplus/ForwardTranslator/ForwardTranslateBoilerHotWater.cpp
if ((value = modelObject.parasiticElectricLoad())) {
idfObject.setDouble(Boiler_HotWaterFields::OnCycleParasiticElectricLoad, value.get());
}
idfObject.setDouble(Boiler_HotWaterFields::OnCycleParasiticElectricLoad, modelObject.onCycleParasiticElectricLoad());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

src/energyplus/ForwardTranslator/ForwardTranslateBoilerHotWater.cpp
if ((value = modelObject.offCycleParasiticFuelLoad())) {
idfObject.setDouble(Boiler_HotWaterFields::OffCycleParasiticFuelLoad, value.get());
}
idfObject.setDouble(Boiler_HotWaterFields::OffCycleParasiticFuelLoad, modelObject.offCycleParasiticFuelLoad());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this one too

src/osversion/VersionTranslator.cpp Show resolved Hide resolved
src/model/BoilerHotWater.cpp Outdated Show resolved Hide resolved
@jmarrec jmarrec marked this pull request as ready for review September 27, 2023 23:15
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Sep 27, 2023 •
edited
Loading

CI Results for 0b79413:

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 27, 2023

tested locally, all good. no point waiting.

@jmarrec jmarrec merged commit 9b40f51 into v23.2.0-IOFreeze Sep 27, 2023
@jmarrec jmarrec deleted the boiler-hot-water2 branch September 27, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarrec jmarrec jmarrec approved these changes

Assignees

@joseph-robertson joseph-robertson

Labels
Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
OpenStudio SDK 3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joseph-robertson @ci-commercialbuildings @jmarrec