Fix #4911 - Avoid extra warning message in ShadingControl

[jmarrec]

Pull request overview

• Fix Systematic warnings with setShadingControlType + setSetpoint(s) #4911
• Avoid extra warning message in ShadingControl

FYI @brgix

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

This was a bug found by @brgix

[jmarrec]

Removing this block that was a TODO and issues an unnecessary Warn

[jmarrec]

Testing the code from the #4911 with this branch. First test code, warning is removed

[1] OS-build-release(main)> model = OpenStudio::Model::Model.new
=> #<OpenStudio::Model::Model:0x000055d047110f40 @__swigtype__="_p_openstudio__model__Model">
[2] OS-build-release(main)> shd = OpenStudio::Model::Shade.new(model)
=> #<OpenStudio::Model::Shade:0x000055d04708b1d8 @__swigtype__="_p_openstudio__model__Shade">
[3] OS-build-release(main)> ctl = OpenStudio::Model::ShadingControl.new(shd)
=> #<OpenStudio::Model::ShadingControl:0x000055d047019f88 @__swigtype__="_p_openstudio__model__ShadingControl">
[4] OS-build-release(main)> ctl.setSetpoint(18)
=> true
[5] OS-build-release(main)> ctl.setShadingControlType("OnIfHighOutdoorAirTempAndHighSolarOnWindow")
=> true

Here you still get the warning that tells you you are setting a Setpoint2 when it's not needed. Which I think is fine IMHO.

[7] OS-build-release(main)> model = OpenStudio::Model::Model.new
=> #<OpenStudio::Model::Model:0x000055d046e2a308 @__swigtype__="_p_openstudio__model__Model">
[8] OS-build-release(main)> shd = OpenStudio::Model::Shade.new(model)
=> #<OpenStudio::Model::Shade:0x000055d046da9140 @__swigtype__="_p_openstudio__model__Shade">
[9] OS-build-release(main)> ctl = OpenStudio::Model::ShadingControl.new(shd)
=> #<OpenStudio::Model::ShadingControl:0x000055d046d23ef0 @__swigtype__="_p_openstudio__model__ShadingControl">
[10] OS-build-release(main)> ctl.setSetpoint(18)
=> true
[11] OS-build-release(main)> ctl.setSetpoint2(100)
[openstudio.model.ShadingControl] <0> Object of type 'OS:ShadingControl' and named 'Shading Control 1' has a Shading Control Type 'OnIfHighSolarOnWindow' which does not require a Setpoint2
=> false
[12] OS-build-release(main)> ctl.setShadingControlType("OnIfHighOutdoorAirTempAndHighSolarOnWindow")
=> true

Test 1
-[openstudio.model.ShadingControl] <0> Object of type 'OS:ShadingControl' and named 'Shading Control 1' has a Shading Control Type 'OnIfHighOutdoorAirTempAndHighSolarOnWindow' which does require a Setpoint, not resetting it


Test 2
[openstudio.model.ShadingControl] <0> Object of type 'OS:ShadingControl' and named 'Shading Control 1' has a Shading Control Type 'OnIfHighSolarOnWindow' which does not require a Setpoint2
-[openstudio.model.ShadingControl] <0> Object of type 'OS:ShadingControl' and named 'Shading Control 1' has a Shading Control Type 'OnIfHighOutdoorAirTempAndHighSolarOnWindow' which does require a Setpoint, not resetting it

[ci-commercialbuildings]

CI Results for c92ab5f:

• Ubuntu 20.04:

  • OpenStudio-3.7.0-alpha+c92ab5fe79-Ubuntu-20.04-x86_64.deb
  • OpenStudio-3.7.0-alpha+c92ab5fe79-Ubuntu-20.04-x86_64.tar.gz
  • perf_test/results.html

• Ubuntu 22.04:

  • OpenStudio-3.7.0-alpha+c92ab5fe79-Ubuntu-22.04-x86_64.deb
  • OpenStudio-3.7.0-alpha+c92ab5fe79-Ubuntu-22.04-x86_64.tar.gz

• Darwin:

  • OpenStudio-3.7.0-alpha+c92ab5fe79-Darwin-x86_64.dmg
  • OpenStudio-3.7.0-alpha+c92ab5fe79-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.7.0-alpha+c92ab5fe79-Windows.exe
  • OpenStudio-3.7.0-alpha+c92ab5fe79-Windows.tar.gz

• Code Coverage: