Lint geometry_improvements and use const refs #4238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
changed the title
jmarrec
added
the
Pull Request - Ready for CI
(to match existing `openstudio::getNewallVector`)
jmarrec
force-pushed
the
geometry_improvements_mod
branch
from
ba6e55b to
15db807
Compare
|
CI Results for 15db807:
|
|
I temporarily pointed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Proposed changes to PR #4221
Lint geometry_improvements and use const refs + rename to NewallVecto…r (to match existing
openstudio::getNewallVector)@ggartside I'll let you review and determine whether they make sense or not, and whether you want to pull them into your branch.